Skip to content

fix: update URL if Vite reload happens during navigation - #12375

Merged
Artur- merged 4 commits into
masterfrom
update-url-during-navi
Nov 17, 2021
Merged

Artur- merged 4 commits into
masterfrom
update-url-during-navi

Conversation

@Artur-

@Artur- Artur- commented Nov 16, 2021

Copy link
Copy Markdown
Member

Fixes #12179

@Artur-

Artur- commented Nov 16, 2021

Copy link
Copy Markdown
Member Author

Still needs a test

@Artur-
Artur- force-pushed the update-url-during-navi branch 2 times, most recently from 6a13a28 to ac37b80 Compare November 16, 2021 15:12
@Artur-
Artur- force-pushed the update-url-during-navi branch from ac37b80 to a45b67a Compare November 16, 2021 17:44
@Artur-
Artur- force-pushed the update-url-during-navi branch from a45b67a to 9062eda Compare November 16, 2021 18:11
@Artur-
Artur- requested review from caalador and joheriks November 17, 2021 10:25
…Tasks.java

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@caalador

Copy link
Copy Markdown
Contributor

Formatter needs running.

@Artur-

Artur- commented Nov 17, 2021

Copy link
Copy Markdown
Member Author

Formatted, resolved conflicts

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR NodeTasks.java#L1: Class com.vaadin.flow.server.frontend.NodeTasks$Builder defines non-transient non-serializable instance field lookup rule
  2. MAJOR NodeTasks.java#L148: Make "lookup" transient or serializable. rule

@Artur-
Artur- enabled auto-merge (squash) November 17, 2021 13:32
@Artur-
Artur- merged commit 273b195 into master Nov 17, 2021
@Artur-
Artur- deleted the update-url-during-navi branch November 17, 2021 13:36
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.rc1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vite] Dependency loading prevents navigation

3 participants