Skip to content

fix: Make linking to packages in the file system work - #12424

Merged
joheriks merged 2 commits into
masterfrom
pkg-filesystem-imports
Dec 6, 2021
Merged

joheriks merged 2 commits into
masterfrom
pkg-filesystem-imports

Conversation

@Artur-

@Artur- Artur- commented Nov 23, 2021

Copy link
Copy Markdown
Member

@Artur-
Artur- force-pushed the pkg-filesystem-imports branch from d7f84fa to e47614c Compare November 23, 2021 09:17
@Artur-
Artur- requested a review from joheriks November 23, 2021 09:17
@haijian-vaadin haijian-vaadin added hilla Issues related to Hilla and removed hilla Issues related to Hilla labels Nov 23, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   714 files     714 suites   17m 37s ⏱️
5 602 tests 5 553 ✔️ 49 💤 0 ❌
5 618 runs  5 569 ✔️ 49 💤 0 ❌

Results for commit 7d48e00.

@Artur-

Artur- commented Dec 3, 2021

Copy link
Copy Markdown
Member Author

This would also help in creating tests for #12512

@Artur-
Artur- requested a review from caalador December 3, 2021 14:40
@joheriks

joheriks commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

This makes sense to have in the LTS but needs a manual cherry-pick since the test module doesn't exist there. Should be fine to merge untested into 2.8 since NodeUpdater changes are going to come from master so regressions would be caught earlier.

@joheriks
joheriks merged commit 7bf9cbf into master Dec 6, 2021
@joheriks
joheriks deleted the pkg-filesystem-imports branch December 6, 2021 13:19
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @joheriks, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 7bf9cbf
error: could not apply 7bf9cbf... fix: Make linking to packages in the file system work (#12424)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@ZheSun88

Copy link
Copy Markdown
Member

CP 2.8 : #14590

mshabarov pushed a commit that referenced this pull request Sep 27, 2022
this is a cherry-pick based on #12424.
as instructed by #12424 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support local paths ("file:..." versions) in package.json dependencies

6 participants