Skip to content

fix: remove duplicates when collecting BeforeEnterObservers - #12451

Merged
caalador merged 1 commit into
masterfrom
fix-preserve-on-refresh-redundant-before-enter
Nov 30, 2021
Merged

caalador merged 1 commit into
masterfrom
fix-preserve-on-refresh-redundant-before-enter

Conversation

@joheriks

@joheriks joheriks commented Nov 25, 2021 •

Copy link
Copy Markdown
Contributor

Description

Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@caalador
caalador merged commit 18f8db9 into master Nov 30, 2021
@caalador
caalador deleted the fix-preserve-on-refresh-redundant-before-enter branch November 30, 2021 05:15
vaadin-bot pushed a commit that referenced this pull request Nov 30, 2021
Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356
vaadin-bot pushed a commit that referenced this pull request Nov 30, 2021
Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356
vaadin-bot pushed a commit that referenced this pull request Nov 30, 2021
Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356
vaadin-bot pushed a commit that referenced this pull request Nov 30, 2021
Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356
vaadin-bot added a commit that referenced this pull request Nov 30, 2021
…12475)

Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
vaadin-bot added a commit that referenced this pull request Nov 30, 2021
…12477)

Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
vaadin-bot added a commit that referenced this pull request Nov 30, 2021
…12476)

Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
vaadin-bot added a commit that referenced this pull request Nov 30, 2021
…12478)

Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components.

Fixes #12356

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

beforeEnter is called multiple times with @PreserveOnRefresh

3 participants