Skip to content

fix: Render only one error page when trying to go to a view without access - #12473

Merged
Artur- merged 1 commit into
masterfrom
one-error-page
Nov 30, 2021
Merged

Artur- merged 1 commit into
masterfrom
one-error-page

Conversation

@Artur-

@Artur- Artur- commented Nov 29, 2021 •

Copy link
Copy Markdown
Member

The current behavior renders an additional error page below the current error page if an error occurs when navigating from the error page (which happens if you click on a view you do not have access to)

@Artur-
Artur- requested a review from caalador November 29, 2021 14:14
@Artur-
Artur- enabled auto-merge (squash) November 29, 2021 14:15
@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   714 files     714 suites   19m 53s ⏱️
5 602 tests 5 553 ✔️ 49 💤 0 ❌
5 615 runs  5 566 ✔️ 49 💤 0 ❌

Results for commit ba138ae.

@Artur-
Artur- merged commit d51759c into master Nov 30, 2021
@Artur-
Artur- deleted the one-error-page branch November 30, 2021 05:10
vaadin-bot pushed a commit that referenced this pull request Nov 30, 2021
…ccess (#12473)

Before this, an additional error page was rendered below the current error page if an error occured when navigating from the error page (which happens if you click on a view you do not have access to)
vaadin-bot added a commit that referenced this pull request Nov 30, 2021
…ccess (#12473) (#12479)

Before this, an additional error page was rendered below the current error page if an error occured when navigating from the error page (which happens if you click on a view you do not have access to)

Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants