Skip to content

fix: Do not throw NPE for UI.access called when session has expired - #12531

Merged
caalador merged 4 commits into
masterfrom
no-npe-in-ui-access
Dec 9, 2021
Merged

caalador merged 4 commits into
masterfrom
no-npe-in-ui-access

Conversation

@Artur-

@Artur- Artur- commented Dec 8, 2021

Copy link
Copy Markdown
Member

Fixes #12100

@github-actions

github-actions Bot commented Dec 8, 2021 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   720 files     720 suites   21m 27s ⏱️
5 648 tests 5 598 ✔️ 50 💤 0 ❌
5 664 runs  5 614 ✔️ 50 💤 0 ❌

Results for commit 194cfdb.

♻️ This comment has been updated with latest results.

@Artur-
Artur- requested a review from caalador December 8, 2021 09:32
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Dec 8, 2021
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Dec 8, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 3 issues

  1. MAJOR UI.java#L519: Reduce this anonymous class number of lines from 30 to at most 20, or make it a named class. rule
  2. MAJOR UI.java#L1030: Call "Optional#isPresent()" before accessing the value. rule
  3. MINOR UI.java#L1019: Remove the declaration of thrown exception 'java.lang.IllegalArgumentException' which is a runtime exception. rule

@caalador
caalador merged commit b760910 into master Dec 9, 2021
@caalador
caalador deleted the no-npe-in-ui-access branch December 9, 2021 08:57
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick b760910
error: could not apply b760910... fix: Do not throw NPE for UI.access called when session has expired (#12531)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@Artur-

Artur- commented Dec 9, 2021

Copy link
Copy Markdown
Member Author

#12547

caalador added a commit that referenced this pull request Dec 16, 2021
vaadin-bot pushed a commit that referenced this pull request Dec 16, 2021
vaadin-bot added a commit that referenced this pull request Dec 16, 2021
…12531) (#12591) (#12596)

Fixes #12100

Co-authored-by: Artur <artur@vaadin.com>

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException: Cannot invoke "com.vaadin.flow.server.VaadinSession.getErrorHandler()" logged when session is closed

3 participants