Repository navigation
feat: lock versions with npm overrides - #12635
Conversation
|
SonarQube analysis reported 7 issues
|
Should the version validation be updated then? |
|
It would be nice to let the users know that it will work better if you upgrade to npm 8.3+ if they are using an older globally installed node/npm. We cannot really require the latest version of npm though and we need to make sure that node 16 with its bundled npm works in a standard (i.e no addons) project |
|
So if I have an older |
|
Is it enough to mention this in the upgrade guide? For people relying on the pnpm locking and cannot upgrade to npm 8.3, they can keep using pnpm. Could also make it a warning message in the code. |
|
The place you would run into this is most of the time when you get a browser warning that a custom element has already been defined. This would be the best place to provide additional info on how the solve the problem but it feels like a separate issue/pr |
|
Also missing is cleaning of the override in |
Good catch, done |
Co-authored-by: Anton Platonov <anton@vaadin.com>
Co-authored-by: Anton Platonov <anton@vaadin.com>
Co-authored-by: Anton Platonov <anton@vaadin.com>
|
Kudos, SonarCloud Quality Gate passed!
|
As someone who fell in this thread almost by accident, when I saw the issue at pnpm/pnpm#4190, and I don't know much about this project, but I thought to give my two cents, that you could add some version specification in the package.json "engines": {
"npm": ">=8.3.0",
"pnpm": ">=5.10.1"
}
|












Description
How it works?
versions.jsonalso for npm modenpmmode, create an"overrides"section in thepackage.jsonfile if the file does not exist.version.jsonfile, add each dependency to the overrides section as @vaadin/xxx: $@vaadin/xxx if there is no @vaadin/xxx in the "overrides" section.Requires npm 8.3.0 or newer which has the "overrids" feature.
Fixes vaadin/hilla#164
Type of change
Checklist
Additional for
Featuretype of change