Skip to content

refactor!: rename Fusion to Hilla - #12672

Merged
haijian-vaadin merged 15 commits into
masterfrom
ap/refactor/rename-fusion-hilla
Jan 7, 2022
Merged

haijian-vaadin merged 15 commits into
masterfrom
ap/refactor/rename-fusion-hilla

Conversation

@platosha

@platosha platosha commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

Connected to vaadin/hilla#176

@platosha platosha added the hilla Issues related to Hilla label Jan 4, 2022
@github-actions

github-actions Bot commented Jan 4, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   769 files  ±0     769 suites  ±0   25m 57s ⏱️ + 1m 50s
5 740 tests ±0  5 688 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
5 772 runs   - 1  5 719 ✔️  - 1  53 💤 ±0  0 ❌ ±0 

Results for commit 406b649. ± Comparison against base commit 06c9248.

♻️ This comment has been updated with latest results.

@platosha
platosha marked this pull request as ready for review January 5, 2022 08:04
Comment thread scripts/computeMatrix.js Outdated
'flow-tests/test-embedding/test-embedding-generic': { weight: 2 },
'flow-tests/test-embedding/test-embedding-reusable-theme': { weight: 2 },
'flow-tests/test-fusion-csrf-context': { weight: 2 },
'flow-tests/test-hilla-csrf-context': { weight: 2 },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSC_DUPLICATE_MEMBER: Class or object literal contains duplicate member "flow-tests/test-hilla-csrf-context". In non-strict code, the last duplicate will overwrite the others.
(at-me in a reply with help or ignore)

return str.matches("(NonNull|NotNull|NotEmpty|NotBlank)\\(.+")
|| str.matches("Size\\(\\{.*min:[^0].+");
|| str.matches("Size\\(.+")
&& Pattern.compile("\\bmin:[^0]").matcher(str).find();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OperatorPrecedence: Use grouping parenthesis to make the operator precedence explicit (details)
(at-me in a reply with help or ignore)

@sonarqubecloud

sonarqubecloud Bot commented Jan 5, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 123 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haijian-vaadin
haijian-vaadin merged commit bd1a188 into master Jan 7, 2022
@haijian-vaadin
haijian-vaadin deleted the ap/refactor/rename-fusion-hilla branch January 7, 2022 12:36
platosha added a commit that referenced this pull request Jan 10, 2022
haijian-vaadin pushed a commit that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hilla Issues related to Hilla +1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants