Skip to content

fix: --openssl-legacy-provider also in build-frontend - #12726

Merged
Artur- merged 6 commits into
masterfrom
fix-node17-in-prod-mode
Jan 17, 2022
Merged

Artur- merged 6 commits into
masterfrom
fix-node17-in-prod-mode

Conversation

@joheriks

@joheriks joheriks commented Jan 14, 2022 •

Copy link
Copy Markdown
Contributor

Need to pass --openssl-legacy-provider to make
Webpack 4 work with Node 17 in some cases. Now
also when invoked as part of build-frontend.

Fixes #12732

@github-actions

github-actions Bot commented Jan 14, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   769 files  ±0     769 suites  ±0   27m 19s ⏱️ + 2m 11s
5 742 tests ±0  5 690 ✔️ +1  52 💤 ±0  0 ❌  - 1 
5 777 runs  +2  5 724 ✔️ +3  53 💤 ±0  0 ❌  - 1 

Results for commit a5b7026. ± Comparison against base commit 6b67898.

♻️ This comment has been updated with latest results.

Artur-
Artur- previously approved these changes Jan 14, 2022
@joheriks
joheriks force-pushed the fix-node17-in-prod-mode branch from b54d879 to a5b7026 Compare January 16, 2022 19:35
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur-
Artur- merged commit 71c71a7 into master Jan 17, 2022
@Artur-
Artur- deleted the fix-node17-in-prod-mode branch January 17, 2022 07:17
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @joheriks and @Artur-, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 71c71a7
error: could not apply 71c71a7... fix: --openssl-legacy-provider also in build-frontend (#12726)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

joheriks pushed a commit that referenced this pull request Jan 17, 2022
Need to pass --openssl-legacy-provider to make Webpack 4 work with Node 17 in some cases. Now also when invoked as part of build-frontend.

Fixes #12732
joheriks pushed a commit that referenced this pull request Jan 18, 2022
Need to pass --openssl-legacy-provider to make Webpack 4 work with Node 17 in some cases. Now also when invoked as part of build-frontend.

Fixes #12732
caalador pushed a commit that referenced this pull request Jan 18, 2022
Need to pass --openssl-legacy-provider to make Webpack 4 work with Node 17 in some cases. Now also when invoked as part of build-frontend.

Fixes #12732
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha3 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vaadin 23.0.0.alpha2 uses nodejs v17.3.0 by default which fails to build the production artifact

3 participants