Skip to content

fix: use bundle-version instead of package version - #12785

Merged
Artur- merged 1 commit into
masterfrom
joheriks/use-bundle-version-atmosphere
Jan 21, 2022
Merged

Artur- merged 1 commit into
masterfrom
joheriks/use-bundle-version-atmosphere

Conversation

@joheriks

@joheriks joheriks commented Jan 20, 2022 •

Copy link
Copy Markdown
Contributor

The customized atmosphere-runtime:2.7.3.slf4jvaadin3 exports packages
with version 2.7.3 (i.e., not 2.7.3.slf4jvaadin3). Depend on exporting bundle
version instead of the package version.

The modified atmosphere-runtime:2.7.3.slf4jvaadin3 exports packages
with version 2.7.3 (i.e., not 2.7.3.slf4jvaadin3). Depend on bundle version
instead of the package version.

http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.importpackage
@joheriks joheriks added the OSGi label Jan 20, 2022
@joheriks
joheriks requested a review from Artur- January 20, 2022 21:32
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   770 files  ±0     770 suites  ±0   24m 32s ⏱️ - 1m 24s
5 744 tests ±0  5 693 ✔️ +2  51 💤 ±0  0 ❌  - 2 
5 777 runs  +1  5 725 ✔️ +3  52 💤 ±0  0 ❌  - 2 

Results for commit 7f9bac1. ± Comparison against base commit 897d1d4.

@Artur-
Artur- merged commit eaad21e into master Jan 21, 2022
@Artur-
Artur- deleted the joheriks/use-bundle-version-atmosphere branch January 21, 2022 08:02
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version.

mcollovati pushed a commit that referenced this pull request Mar 29, 2022
The modified atmosphere-runtime:2.7.3.slf4jvaadin3 exports packages
with version 2.7.3 (i.e., not 2.7.3.slf4jvaadin3). Depend on bundle version
instead of the package version.

http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.importpackage
caalador pushed a commit that referenced this pull request Mar 30, 2022
The modified atmosphere-runtime:2.7.3.slf4jvaadin3 exports packages
with version 2.7.3 (i.e., not 2.7.3.slf4jvaadin3). Depend on bundle version
instead of the package version.

http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.importpackage

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
vaadin-bot pushed a commit that referenced this pull request Mar 30, 2022
The modified atmosphere-runtime:2.7.3.slf4jvaadin3 exports packages
with version 2.7.3 (i.e., not 2.7.3.slf4jvaadin3). Depend on bundle version
instead of the package version.

http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.importpackage

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
vaadin-bot added a commit that referenced this pull request Mar 30, 2022
…13394)

The modified atmosphere-runtime:2.7.3.slf4jvaadin3 exports packages
with version 2.7.3 (i.e., not 2.7.3.slf4jvaadin3). Depend on bundle version
instead of the package version.

http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module.importpackage

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants