Repository navigation
fix: handle faulty imports - #12793
Conversation
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
169912a to
4e4d79a
Compare
|
The original |
Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
|
The main reason is that it is used to clean the |
Is |
Well it is for polymer template and there it is actually fine to have it with |
Aight, my suggestion would be to refactor the method to reduce the code duplication and mention in the JavaDoc why the parameter is required (different parsing requirements for polymer templates). |
|
Done. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @caalador and @joheriks, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually? |
|
Hi @caalador and @joheriks, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually? |
|
Hi @caalador and @joheriks, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually? |
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765
|
This ticket/PR has been released with platform 23.0.0.beta1 and is also targeting the upcoming stable 23.0.0 version. |








Do not throw silently for incompatible
import paths. Fix comment removal
for JS files to accept ' as string.
fixes #12765