Skip to content

fix: don't mention Webpack in error messages when Vite is used - #12809

Merged
Artur- merged 3 commits into
masterfrom
fix/build-frontend-error-messages
Jan 24, 2022
Merged

Artur- merged 3 commits into
masterfrom
fix/build-frontend-error-messages

Conversation

@vursen

@vursen vursen commented Jan 24, 2022 •

Copy link
Copy Markdown
Contributor

Description

There are some error messages that always mention Webpack as the trouble source even though they are also used for Vite. This PR fixes such messages so that they mention the frontend tool that is actually used.

Fixes #12767

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title fix: don't mention Webpack in error messages about Vite fix: don't mention Webpack in error messages related to Vite Jan 24, 2022
@vursen vursen changed the title fix: don't mention Webpack in error messages related to Vite fix: don't mention Webpack in error messages when Vite is used Jan 24, 2022
@github-actions

github-actions Bot commented Jan 24, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   770 files  ±0     770 suites  ±0   25m 43s ⏱️ + 1m 22s
5 745 tests ±0  5 694 ✔️ ±0  51 💤 ±0  0 ❌ ±0 
5 778 runs  +5  5 726 ✔️ +5  52 💤 ±0  0 ❌ ±0 

Results for commit 1395c67. ± Comparison against base commit 612395e.

♻️ This comment has been updated with latest results.

@vursen
vursen requested a review from Artur- January 24, 2022 10:45
@Artur-
Artur- enabled auto-merge (squash) January 24, 2022 10:50
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vite] Some error messages mention Webpack regardless of which frontend tool is actually used

3 participants