Skip to content

fix: do not store UI reference in DataCommunicator - #12849

Merged
joheriks merged 1 commit into
masterfrom
joheriks/do-not-store-ui-in-datacommunicator
Jan 26, 2022
Merged

joheriks merged 1 commit into
masterfrom
joheriks/do-not-store-ui-in-datacommunicator

Conversation

@joheriks

Copy link
Copy Markdown
Contributor

Fixes a deserialization problem.
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joheriks

joheriks commented Jan 26, 2022 •

Copy link
Copy Markdown
Contributor Author

DataCommunicator async feature is not targeted for 9/2.7 as it is a new API. Most likely the 2.8 is going to need manual cherry pick because differences.

@joheriks
joheriks enabled auto-merge (squash) January 26, 2022 11:48
@github-actions

github-actions Bot commented Jan 26, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   774 files  ±0     774 suites  ±0   27m 26s ⏱️ - 1m 1s
5 757 tests ±0  5 707 ✔️ +1  50 💤 ±0  0 ❌  - 1 
5 787 runs   - 2  5 736 ✔️  - 1  51 💤 ±0  0 ❌  - 1 

Results for commit d47a3aa. ± Comparison against base commit 64c88a4.

♻️ This comment has been updated with latest results.

@joheriks
joheriks merged commit 138fc89 into master Jan 26, 2022
@joheriks
joheriks deleted the joheriks/do-not-store-ui-in-datacommunicator branch January 26, 2022 12:43
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @joheriks and @joheriks, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 138fc89
error: could not apply 138fc89... fix: do not store UI reference in DataCommunicator (#12849)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @joheriks and @joheriks, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 138fc89
error: could not apply 138fc89... fix: do not store UI reference in DataCommunicator (#12849)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.beta1 and is also targeting the upcoming stable 23.0.0 version.

@ZheSun88

Copy link
Copy Markdown
Member

2.8 CP :#14592

mshabarov pushed a commit that referenced this pull request Sep 22, 2022
Fixes a deserialization problem.

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants