Skip to content

fix: Do not log conversion error in StringToUuidConverter - #12882

Merged
joheriks merged 1 commit into
masterfrom
Artur--patch-3
Jan 28, 2022
Merged

joheriks merged 1 commit into
masterfrom
Artur--patch-3

Conversation

@Artur-

@Artur- Artur- commented Jan 28, 2022

Copy link
Copy Markdown
Member

No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs

No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented Jan 28, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   773 files  ±0     773 suites  ±0   28m 7s ⏱️ - 2m 37s
5 769 tests ±0  5 722 ✔️ +1  47 💤  - 1  0 ❌ ±0 
5 802 runs  ±0  5 754 ✔️ +1  48 💤  - 1  0 ❌ ±0 

Results for commit 3f55f81. ± Comparison against base commit 721d966.

♻️ This comment has been updated with latest results.

@joheriks
joheriks enabled auto-merge (squash) January 28, 2022 16:01
@joheriks
joheriks merged commit 295b929 into master Jan 28, 2022
@joheriks
joheriks deleted the Artur--patch-3 branch January 28, 2022 16:17
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @joheriks, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 295b929
error: could not apply 295b929... fix: Do not log conversion error (#12882)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot pushed a commit that referenced this pull request Jan 28, 2022
No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @joheriks, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 295b929
error: could not apply 295b929... fix: Do not log conversion error (#12882)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Artur- added a commit that referenced this pull request Jan 28, 2022
No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
Artur- added a commit that referenced this pull request Jan 28, 2022
No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
Artur- pushed a commit that referenced this pull request Jan 30, 2022
No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
Artur- added a commit that referenced this pull request Jan 31, 2022
No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
Artur- added a commit that referenced this pull request Jan 31, 2022
…P: 2.8) (#12886)

No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.beta1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants