Repository navigation
fix!: no double decode query parameters - #12916
Merged
Merged
Conversation
joheriks
force-pushed
the
joheriks/fix-double-decode-query-params
branch
from
February 2, 2022 14:13
df685fd to
4ec83a8
Compare
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParamaters.getQueryString instead of justing joining the decoded strings in the map. This is a potentially breaking change.
joheriks
force-pushed
the
joheriks/fix-double-decode-query-params
branch
from
February 2, 2022 14:18
4ec83a8 to
3ac1731
Compare
Contributor
caalador
requested changes
Feb 3, 2022
caalador
reviewed
Feb 3, 2022
caalador
left a comment
Contributor
There was a problem hiding this comment.
2 Wrong values in assert messages.
added 2 commits
February 3, 2022 12:02
caalador
approved these changes
Feb 3, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParameters.getQueryString. This is a potentially breaking change, as previously these were not encoded before being joined.
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParameters.getQueryString. This is a potentially breaking change, as previously these were not encoded before being joined.
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParameters.getQueryString. This is a potentially breaking change, as previously these were not encoded before being joined.
vaadin-bot
added a commit
that referenced
this pull request
Feb 3, 2022
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParameters.getQueryString. This is a potentially breaking change, as previously these were not encoded before being joined. Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
joheriks
pushed a commit
that referenced
this pull request
Feb 4, 2022
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParameters.getQueryString. This is a potentially breaking change, as previously these were not encoded before being joined.
joheriks
pushed a commit
that referenced
this pull request
Feb 4, 2022
URI.getQuery decodes the entire query string, making it impossible to distinguish & separating parameters from literal values: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423' Also return a properly encoded query string from QueryParameters.getQueryString. This is a potentially breaking change, as previously these were not encoded before being joined.
Collaborator
|
This ticket/PR has been released with platform 14.8.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fix 1: Don't double-decode query parameters.
Fix 2: URI.getQuery is broken, making it impossible to distinguish
&separatingparameters from literal ampersands:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8214423'
Fix 3: Return a properly encoded query string from
QueryParamaters.getQueryString instead of justing joining the decoded
strings in the map. This is a potentially breaking change.
Fixes #12887