Repository navigation
fix: call history methods with '.' instead of '' - #12991
Merged
caalador merged 1 commit intoFeb 14, 2022
Merged
Conversation
joheriks
force-pushed
the
joheriks/fix-empty-path-history-on-firefox-safari
branch
from
February 10, 2022 17:00
dc93638 to
5f75a3f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Feb 11, 2022
caalador
deleted the
joheriks/fix-empty-path-history-on-firefox-safari
branch
February 14, 2022 12:09
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History. Fixes #5113
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History. Fixes #5113
joheriks
pushed a commit
that referenced
this pull request
Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History. Fixes #5113 Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
joheriks
pushed a commit
that referenced
this pull request
Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History. Fixes #5113 Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








The API for
Location::getPath/getPathWithQueryParameterswas changed in V15 to return""instead of"."for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method inHistory.Fixes #5113.