Skip to content

fix: call history methods with '.' instead of '' - #12991

Merged
caalador merged 1 commit into
masterfrom
joheriks/fix-empty-path-history-on-firefox-safari
Feb 14, 2022
Merged

caalador merged 1 commit into
masterfrom
joheriks/fix-empty-path-history-on-firefox-safari

Conversation

@joheriks

@joheriks joheriks commented Feb 10, 2022 •

Copy link
Copy Markdown
Contributor

The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History.

Fixes #5113.

@joheriks
joheriks force-pushed the joheriks/fix-empty-path-history-on-firefox-safari branch from dc93638 to 5f75a3f Compare February 10, 2022 17:00
@vaadin vaadin deleted a comment from vaadin-bot Feb 10, 2022
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   775 files  ±0     775 suites  ±0   29m 49s ⏱️ - 5m 33s
5 781 tests +1  5 734 ✔️ +2  47 💤  - 1  0 ❌ ±0 
5 816 runs  +3  5 768 ✔️ +4  48 💤  - 1  0 ❌ ±0 

Results for commit 5f75a3f. ± Comparison against base commit 1322902.

@joheriks joheriks changed the title fix: push '.' instead of '' when navigating fix: call history methods with '.' instead of '' Feb 10, 2022
@caalador
caalador merged commit e802db9 into master Feb 14, 2022
@caalador
caalador deleted the joheriks/fix-empty-path-history-on-firefox-safari branch February 14, 2022 12:09
vaadin-bot pushed a commit that referenced this pull request Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History.

Fixes #5113
vaadin-bot pushed a commit that referenced this pull request Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History.

Fixes #5113
joheriks pushed a commit that referenced this pull request Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History.

Fixes #5113

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
joheriks pushed a commit that referenced this pull request Feb 14, 2022
The API for Location::getPath/getPathWithQueryParameters was changed in V15 to return "" instead of "." for the base URL. However, it seems to not have been taken into account that FF / Safari do not navigate to base when passing the empty string for URL to the history methods (and this ticket, which seems to have observed that this workaround was necessary, was closed without action). This commit moves the workaround to its own method in History.

Fixes #5113

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigating back to main view don't work in FF and Safari

3 participants