Repository navigation
feat: Add modality helpers - #13026
Merged
Merged
Conversation
Add methods to check if there is a modal component set and to add component to current modal component. Fixes #12992
joheriks
reviewed
Feb 15, 2022
| * | ||
| * @return {@code true} if a modal component has been set | ||
| */ | ||
| public boolean hasModal() { |
Contributor
There was a problem hiding this comment.
Maybe this could also be called hasModalComponent to give a bit more context as UI contains a lot of things, and to be consistent with addToModalComponent.
| if (activeModalComponent instanceof HasComponents) { | ||
| ((HasComponents) activeModalComponent).add(component); | ||
| } else { | ||
| activeModalComponent.getElement() |
There was a problem hiding this comment.
NULL_DEREFERENCE: object activeModalComponent last assigned on line 1317 could be null and is dereferenced at line 1321.
(at-me in a reply with help or ignore)
|
Kudos, SonarCloud Quality Gate passed!
|
anssit
approved these changes
Feb 16, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Add methods to check if there is a modal component set and to add component to current modal component. Fixes #12992
joheriks
pushed a commit
that referenced
this pull request
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Add methods to check if there is a
modal component set and to add
component to current modal component.
Fixes #12992