Skip to content

fix: shortcut event to modal component instead of UI - #13263

Merged
caalador merged 2 commits into
masterfrom
joheriks/fix-shortcut-on-modal-component
Mar 10, 2022
Merged

caalador merged 2 commits into
masterfrom
joheriks/fix-shortcut-on-modal-component

Conversation

@joheriks

@joheriks joheriks commented Mar 9, 2022 •

Copy link
Copy Markdown
Contributor

If the UI is overlaid by a modal component, shortcut
events to UI are ignored; so send them from the active
modal component instead.

Fixes #13205

If the UI is overlaid by a modal component, shortcut
events to UI are ignored; send them from the active
modalcomponent instead.

Fixes #13205
@github-actions

github-actions Bot commented Mar 9, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   948 files  ±0     948 suites  ±0   44m 59s ⏱️ +49s
6 158 tests +1  6 109 ✔️ +1  49 💤 ±0  0 ❌ ±0 
6 376 runs  +4  6 321 ✔️ +4  55 💤 ±0  0 ❌ ±0 

Results for commit 934fe56. ± Comparison against base commit 88610e4.

♻️ This comment has been updated with latest results.

@joheriks
joheriks force-pushed the joheriks/fix-shortcut-on-modal-component branch from ef84ee5 to 934fe56 Compare March 10, 2022 06:43
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joheriks
joheriks requested a review from caalador March 10, 2022 07:21
@caalador
caalador merged commit 1392597 into master Mar 10, 2022
@caalador
caalador deleted the joheriks/fix-shortcut-on-modal-component branch March 10, 2022 09:04
vaadin-bot pushed a commit that referenced this pull request Mar 10, 2022
If the UI is overlaid by a modal component, shortcut
events to UI are ignored; send them from the active
modalcomponent instead.

Fixes #13205
caalador pushed a commit that referenced this pull request Mar 10, 2022
If the UI is overlaid by a modal component, shortcut
events to UI are ignored; send them from the active
modalcomponent instead.

Fixes #13205

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
joheriks pushed a commit that referenced this pull request Mar 11, 2022
The previous fix for #13205 (PR #13263) moved all shortcut
registration event sources from UI to the modal component
if one was active; this caused shortcuts owned by components
not under the modal tree to also be moved if they were registered
when a modal component was active, and hence they stopped
working when the modal component tree was removed. This
modifies the previous fix to only change the event source if the
shortcut owner is under the an active modal tree.
vaadin-bot pushed a commit that referenced this pull request Mar 11, 2022
The previous fix for #13205 (PR #13263) moved all shortcut
registration event sources from UI to the modal component
if one was active; this caused shortcuts owned by components
not under the modal tree to also be moved if they were registered
when a modal component was active, and hence they stopped
working when the modal component tree was removed. This
modifies the previous fix to only change the event source if the
shortcut owner is under the an active modal tree.
joheriks pushed a commit that referenced this pull request Mar 14, 2022
…13276)

The previous fix for #13205 (PR #13263) moved all shortcut
registration event sources from UI to the modal component
if one was active; this caused shortcuts owned by components
not under the modal tree to also be moved if they were registered
when a modal component was active, and hence they stopped
working when the modal component tree was removed. This
modifies the previous fix to only change the event source if the
shortcut owner is under the an active modal tree.

Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click shortcut of a Button in a Dialog is not triggered

3 participants