Repository navigation
fix: shortcut event to modal component instead of UI - #13263
Merged
Merged
Conversation
If the UI is overlaid by a modal component, shortcut events to UI are ignored; send them from the active modalcomponent instead. Fixes #13205
Contributor
joheriks
force-pushed
the
joheriks/fix-shortcut-on-modal-component
branch
from
March 10, 2022 06:43
ef84ee5 to
934fe56
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Mar 10, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 10, 2022
If the UI is overlaid by a modal component, shortcut events to UI are ignored; send them from the active modalcomponent instead. Fixes #13205
caalador
pushed a commit
that referenced
this pull request
Mar 10, 2022
joheriks
pushed a commit
that referenced
this pull request
Mar 11, 2022
The previous fix for #13205 (PR #13263) moved all shortcut registration event sources from UI to the modal component if one was active; this caused shortcuts owned by components not under the modal tree to also be moved if they were registered when a modal component was active, and hence they stopped working when the modal component tree was removed. This modifies the previous fix to only change the event source if the shortcut owner is under the an active modal tree.
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
The previous fix for #13205 (PR #13263) moved all shortcut registration event sources from UI to the modal component if one was active; this caused shortcuts owned by components not under the modal tree to also be moved if they were registered when a modal component was active, and hence they stopped working when the modal component tree was removed. This modifies the previous fix to only change the event source if the shortcut owner is under the an active modal tree.
joheriks
pushed a commit
that referenced
this pull request
Mar 14, 2022
…13276) The previous fix for #13205 (PR #13263) moved all shortcut registration event sources from UI to the modal component if one was active; this caused shortcuts owned by components not under the modal tree to also be moved if they were registered when a modal component was active, and hence they stopped working when the modal component tree was removed. This modifies the previous fix to only change the event source if the shortcut owner is under the an active modal tree. Co-authored-by: Johannes Eriksson <joheriks@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








If the UI is overlaid by a modal component, shortcut
events to UI are ignored; so send them from the active
modal component instead.
Fixes #13205