Repository navigation
feat: Allow navigation with RouterLinks when inert - #13331
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Mar 22, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
Server-side modality feature attempted to block navigation when a modal component is active. This blocks some legitimate use cases when one wants to use RouterLinks inside a modal component. With the current router implementation, it is not practically possible to separate between RouterLinks that are inside a modal from those that are outside (inert). Moreover, navigation cannot be fully controlled on the server side anyway. Therefore, the development team decided to reverse the decision to block RouterLinks when the UI is inert. This PR allows navigation via RouterLinks even when the UI is inert. Fixes #13270
caalador
pushed a commit
that referenced
this pull request
Mar 22, 2022
Server-side modality feature attempted to block navigation when a modal component is active. This blocks some legitimate use cases when one wants to use RouterLinks inside a modal component. With the current router implementation, it is not practically possible to separate between RouterLinks that are inside a modal from those that are outside (inert). Moreover, navigation cannot be fully controlled on the server side anyway. Therefore, the development team decided to reverse the decision to block RouterLinks when the UI is inert. This PR allows navigation via RouterLinks even when the UI is inert. Fixes #13270 Co-authored-by: anssit <16914037+anssit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Server-side modality feature attempted to block navigation when a modal component is active. This blocks some legitimate use cases when one wants to use RouterLinks inside a modal component. With the current router implementation, it is not practically possible to separate between RouterLinks that are inside a modal from those that are outside (inert). Moreover, navigation cannot be fully controlled on the server side anyway. Therefore, the development team decided to reverse the decision to block RouterLinks when the UI is inert. This PR allows navigation via RouterLinks even when the UI is inert.
Fixes #13270
Type of change
Checklist
Additional for
Featuretype of change