Skip to content

feat: Allow navigation with RouterLinks when inert - #13331

Merged
caalador merged 3 commits into
masterfrom
revert-routerlink-inertness
Mar 22, 2022
Merged

caalador merged 3 commits into
masterfrom
revert-routerlink-inertness

Conversation

@anssit

@anssit anssit commented Mar 21, 2022 •

Copy link
Copy Markdown
Contributor

Description

Server-side modality feature attempted to block navigation when a modal component is active. This blocks some legitimate use cases when one wants to use RouterLinks inside a modal component. With the current router implementation, it is not practically possible to separate between RouterLinks that are inside a modal from those that are outside (inert). Moreover, navigation cannot be fully controlled on the server side anyway. Therefore, the development team decided to reverse the decision to block RouterLinks when the UI is inert. This PR allows navigation via RouterLinks even when the UI is inert.

Fixes #13270

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   954 files  ±0     954 suites  ±0   42m 49s ⏱️ - 4m 45s
6 179 tests ±0  6 131 ✔️ +1  48 💤  - 1  0 ❌ ±0 
6 396 runs  +6  6 342 ✔️ +4  54 💤 +2  0 ❌ ±0 

Results for commit adcb45d. ± Comparison against base commit e740ce5.

@caalador
caalador merged commit 8ea3378 into master Mar 22, 2022
@caalador
caalador deleted the revert-routerlink-inertness branch March 22, 2022 11:30
vaadin-bot pushed a commit that referenced this pull request Mar 22, 2022
Server-side modality feature attempted to block navigation when a modal component is active. This blocks some legitimate use cases when one wants to use RouterLinks inside a modal component. With the current router implementation, it is not practically possible to separate between RouterLinks that are inside a modal from those that are outside (inert). Moreover, navigation cannot be fully controlled on the server side anyway. Therefore, the development team decided to reverse the decision to block RouterLinks when the UI is inert. This PR allows navigation via RouterLinks even when the UI is inert.

Fixes #13270
caalador pushed a commit that referenced this pull request Mar 22, 2022
Server-side modality feature attempted to block navigation when a modal component is active. This blocks some legitimate use cases when one wants to use RouterLinks inside a modal component. With the current router implementation, it is not practically possible to separate between RouterLinks that are inside a modal from those that are outside (inert). Moreover, navigation cannot be fully controlled on the server side anyway. Therefore, the development team decided to reverse the decision to block RouterLinks when the UI is inert. This PR allows navigation via RouterLinks even when the UI is inert.

Fixes #13270

Co-authored-by: anssit <16914037+anssit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RouterLink is not working inside modal dialog

3 participants