Repository navigation
fix: Not fetch entire page if number of requested items is less - #13580
Merged
Merged
Conversation
Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below Fixes: vaadin-component-factory/selection-grid-flow#34 vaadin-component-factory/selection-grid-flow#16 (comment)
4 of 9 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
caalador
approved these changes
Apr 21, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below Fixes vaadin-component-factory/selection-grid-flow#34 Fixes vaadin-component-factory/selection-grid-flow#16 Co-authored-by: @s76527
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below Fixes vaadin-component-factory/selection-grid-flow#34 Fixes vaadin-component-factory/selection-grid-flow#16 Co-authored-by: @s76527
vaadin-bot
added a commit
that referenced
this pull request
Apr 21, 2022
…) (#13582) Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below Fixes vaadin-component-factory/selection-grid-flow#34 Fixes vaadin-component-factory/selection-grid-flow#16 Co-authored-by: @s76527 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov
added a commit
that referenced
this pull request
Apr 21, 2022
…) (#13581) Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below Fixes vaadin-component-factory/selection-grid-flow#34 Fixes vaadin-component-factory/selection-grid-flow#16 Co-authored-by: @s76527 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.alpha3 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below
Fixes:
vaadin-component-factory/selection-grid-flow#34
vaadin-component-factory/selection-grid-flow#16 (comment)
Co-authored-by: @s76527
Type of change
Checklist
Additional for
Featuretype of change