Skip to content

fix: Not fetch entire page if number of requested items is less - #13580

Merged
caalador merged 1 commit into
masterfrom
fix/use-limit-not-page
Apr 21, 2022
Merged

caalador merged 1 commit into
masterfrom
fix/use-limit-not-page

Conversation

@mshabarov

@mshabarov mshabarov commented Apr 20, 2022 •

Copy link
Copy Markdown
Contributor

Description

Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below

Fixes:
vaadin-component-factory/selection-grid-flow#34
vaadin-component-factory/selection-grid-flow#16 (comment)

Co-authored-by: @s76527

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below

Fixes:

vaadin-component-factory/selection-grid-flow#34
vaadin-component-factory/selection-grid-flow#16 (comment)
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented Apr 20, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   959 files  ±  0     959 suites  ±0   51m 9s ⏱️ + 1m 34s
6 216 tests ±  0  6 168 ✔️ +  1  48 💤  - 1  0 ❌ ±0 
6 444 runs  +11  6 390 ✔️ +12  54 💤  - 1  0 ❌ ±0 

Results for commit 00e149c. ± Comparison against base commit 92d04a0.

♻️ This comment has been updated with latest results.

@caalador
caalador merged commit 33093a4 into master Apr 21, 2022
@caalador
caalador deleted the fix/use-limit-not-page branch April 21, 2022 03:59
vaadin-bot pushed a commit that referenced this pull request Apr 21, 2022
Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below

Fixes vaadin-component-factory/selection-grid-flow#34
Fixes vaadin-component-factory/selection-grid-flow#16

Co-authored-by: @s76527
vaadin-bot pushed a commit that referenced this pull request Apr 21, 2022
Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below

Fixes vaadin-component-factory/selection-grid-flow#34
Fixes vaadin-component-factory/selection-grid-flow#16

Co-authored-by: @s76527
vaadin-bot added a commit that referenced this pull request Apr 21, 2022
…) (#13582)

Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below

Fixes vaadin-component-factory/selection-grid-flow#34
Fixes vaadin-component-factory/selection-grid-flow#16

Co-authored-by: @s76527

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov added a commit that referenced this pull request Apr 21, 2022
…) (#13581)

Fixes bug that caused Grid with multi select mode to select not only the item that was clicked on, but also every item below

Fixes vaadin-component-factory/selection-grid-flow#34
Fixes vaadin-component-factory/selection-grid-flow#16

Co-authored-by: @s76527

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha3 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants