Skip to content

fix: do not select from session if parent has a better match - #13603

Merged
mcollovati merged 2 commits into
masterfrom
issues/13348_session-wildcard-not-override
Apr 26, 2022
Merged

mcollovati merged 2 commits into
masterfrom
issues/13348_session-wildcard-not-override

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Check if parent registry contains a better match
than the session registry.

Fixes #13348

@github-actions

github-actions Bot commented Apr 22, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   960 files  +1     960 suites  +1   53m 22s ⏱️ + 2m 5s
6 220 tests +4  6 171 ✔️ +4  49 💤 ±0  0 ❌ ±0 
6 442 runs   - 2  6 387 ✔️  - 2  55 💤 ±0  0 ❌ ±0 

Results for commit 3165c43. ± Comparison against base commit 5dd10fa.

♻️ This comment has been updated with latest results.

Check if parent registry contains a better match
than the session registry.

Fixes #13348
@caalador
caalador force-pushed the issues/13348_session-wildcard-not-override branch from b608360 to c422758 Compare April 22, 2022 12:15
@mshabarov
mshabarov requested a review from mcollovati April 25, 2022 11:30
Co-authored-by: Marco Collovati <marco@vaadin.com>
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Apr 26, 2022
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati
mcollovati merged commit 981e73b into master Apr 26, 2022
@mcollovati
mcollovati deleted the issues/13348_session-wildcard-not-override branch April 26, 2022 09:28
vaadin-bot pushed a commit that referenced this pull request Apr 26, 2022
Check if parent registry contains a better match
than the session registry.

Fixes #13348
vaadin-bot pushed a commit that referenced this pull request Apr 26, 2022
Check if parent registry contains a better match
than the session registry.

Fixes #13348
mcollovati pushed a commit that referenced this pull request Apr 26, 2022
…#13620)

Check if parent registry contains a better match
than the session registry.

Fixes #13348

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 26, 2022
…#13621)

Check if parent registry contains a better match
than the session registry.

Fixes #13348

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha4 and is also targeting the upcoming stable 23.1.0 version.

mshabarov pushed a commit that referenced this pull request Jun 10, 2022
…#13620)

Check if parent registry contains a better match
than the session registry.

Fixes #13348

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
taefi pushed a commit that referenced this pull request Jun 10, 2022
…#13620)

Check if parent registry contains a better match
than the session registry.

Fixes #13348

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
ZheSun88 pushed a commit that referenced this pull request Sep 21, 2022
Check if parent registry contains a better match
than the session registry.

Fixes #13348
mshabarov pushed a commit that referenced this pull request Sep 22, 2022
Check if parent registry contains a better match
than the session registry.

Fixes #13348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dynamic registration of route-template in session-scope might break existing routes of application-scope

3 participants