Skip to content

fix: ignore server-modality for poll RPC invocations - #13604

Merged
taefi merged 7 commits into
masterfrom
taefi/fix-issue-13337
Apr 27, 2022
Merged

taefi merged 7 commits into
masterfrom
taefi/fix-issue-13337

Conversation

@taefi

@taefi taefi commented Apr 22, 2022 •

Copy link
Copy Markdown
Contributor

Description

The inert status of the UI as the result of
server-modality should be ignored for
some RPC calls such as polling events.

Fixes #13337

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

The inert status of the ui due to
server-modality being enabled should
be ignored for some RPC calls such as
polling event when push is enabled.
@github-actions

github-actions Bot commented Apr 22, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   960 files  +  1     960 suites  +1   47m 11s ⏱️ - 4m 6s
6 231 tests +15  6 183 ✔️ +16  48 💤  - 1  0 ❌ ±0 
6 453 runs  +  9  6 399 ✔️ +10  54 💤  - 1  0 ❌ ±0 

Results for commit 5540328. ± Comparison against base commit 5dd10fa.

♻️ This comment has been updated with latest results.

@taefi
taefi requested a review from caalador April 25, 2022 21:28
@taefi
taefi marked this pull request as ready for review April 25, 2022 21:29
taefi and others added 2 commits April 26, 2022 12:48
Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.1.0 labels Apr 26, 2022
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@taefi taefi changed the title fix: ignore server-modality for push RPC invocations fix: ignore server-modality for poll RPC invocations Apr 26, 2022
@taefi
taefi requested a review from caalador April 26, 2022 15:06
@taefi
taefi merged commit ec7e8d0 into master Apr 27, 2022
@taefi
taefi deleted the taefi/fix-issue-13337 branch April 27, 2022 09:58
taefi added a commit that referenced this pull request Apr 27, 2022
Manual CP to 23.0 branch to exclude
the breaking changes of #13604
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha4 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poll listeners are not invoked when a modal dialog is shown

3 participants