Repository navigation
fix: Serialize byte[] as Array<number> - #13656
Merged
Merged
Conversation
Contributor
tarekoraby
force-pushed
the
hilla-serialize-bytes
branch
from
May 6, 2022 11:42
cca1f84 to
45502a9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
platosha
approved these changes
May 6, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 6, 2022
* Serialize byte[] as Array<number> * Remove unused imports * Add test * Fix test * Make inner classes static * Format
Collaborator
|
Hi @tarekoraby and @platosha, when i performed cherry-pick to this commit to 23.0, i have encountered the following issue. Can you take a look and pick it manually? |
platosha
pushed a commit
that referenced
this pull request
May 6, 2022
* Serialize byte[] as Array<number> * Remove unused imports * Add test * Fix test * Make inner classes static * Format (cherry picked from commit 53511df)
platosha
pushed a commit
that referenced
this pull request
May 10, 2022
* Serialize byte[] as Array<number> * Remove unused imports * Add test * Fix test * Make inner classes static * Format Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
platosha
added a commit
that referenced
this pull request
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fix vaadin/hilla#396.