Skip to content

fix: Serialize byte[] as Array<number> - #13656

Merged
platosha merged 6 commits into
masterfrom
hilla-serialize-bytes
May 6, 2022
Merged

platosha merged 6 commits into
masterfrom
hilla-serialize-bytes

Conversation

@tarekoraby

Copy link
Copy Markdown
Contributor

@tarekoraby
tarekoraby requested review from Artur- and platosha April 29, 2022 08:11
@tarekoraby tarekoraby changed the title Serialize byte[] as Array<number> fix: Serialize byte[] as Array<number> Apr 29, 2022
@github-actions

github-actions Bot commented Apr 29, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   961 files  ±0     961 suites  ±0   54m 35s ⏱️ + 4m 34s
6 264 tests +1  6 215 ✔️ +2  49 💤 ±0  0 ❌  - 1 
6 490 runs  +3  6 435 ✔️ +3  55 💤 +1  0 ❌  - 1 

Results for commit b99e141. ± Comparison against base commit ece1db0.

♻️ This comment has been updated with latest results.

@caalador caalador added the hilla Issues related to Hilla label May 2, 2022
@tarekoraby
tarekoraby force-pushed the hilla-serialize-bytes branch from cca1f84 to 45502a9 Compare May 6, 2022 11:42
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha
platosha merged commit 53511df into master May 6, 2022
@platosha
platosha deleted the hilla-serialize-bytes branch May 6, 2022 12:56
vaadin-bot pushed a commit that referenced this pull request May 6, 2022
* Serialize byte[] as Array<number>

* Remove unused imports

* Add test

* Fix test

* Make inner classes static

* Format
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @tarekoraby and @platosha, when i performed cherry-pick to this commit to 23.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 53511df
error: could not apply 53511df... fix: Serialize byte[] as Array (#13656)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

platosha pushed a commit that referenced this pull request May 6, 2022
* Serialize byte[] as Array<number>

* Remove unused imports

* Add test

* Fix test

* Make inner classes static

* Format

(cherry picked from commit 53511df)
platosha pushed a commit that referenced this pull request May 10, 2022
* Serialize byte[] as Array<number>

* Remove unused imports

* Add test

* Fix test

* Make inner classes static

* Format

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
platosha added a commit that referenced this pull request May 11, 2022
* Serialize byte[] as Array<number>

* Remove unused imports

* Add test

* Fix test

* Make inner classes static

* Format

(cherry picked from commit 53511df)

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binding byte[] fields generates an error

4 participants