Repository navigation
fix: Only run new license checker when flag is enabled - #13666
Merged
Merged
Conversation
The checker is invoked in three places: 1. After production build with the plugin 2. For fallback chunk in production build 3. Development time through dev mode gizmo With this addition, all the three places are guarded by the feature flag
Contributor
mcollovati
reviewed
May 3, 2022
Comment on lines
+481
to
+482
| if (!productionMode | ||
| || !featureFlags.isEnabled(FeatureFlags.NEW_LICENSE_CHECKER)) { |
Collaborator
There was a problem hiding this comment.
If I correctly understand with this change we filter modules only if we are in production mode and the feature flag is enabled. If so, maybe inverting the condition may be easier to understand (at least for me)
Member
Author
There was a problem hiding this comment.
Aren't you not a not-fan of weird logic? Fixed
Collaborator
There was a problem hiding this comment.
When I see more that one not, I need pen and paper to figure out how the condition works
mcollovati
approved these changes
May 3, 2022
Artur-
enabled auto-merge (squash)
May 3, 2022 15:59
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.beta1 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








The checker is invoked in three places:
With this addition, all the three places are guarded by the feature flag