Repository navigation
Fix: devmode popup will show Hilla instead of Vaadin in Hilla applications - #13725
Merged
Merged
Conversation
Contributor
Member
|
This will need a rebase now that I went and renamed the dev mode gizmo in #13679 |
Contributor
Author
|
OK I'll take care of that |
cromoteca
marked this pull request as draft
May 12, 2022 14:42
platosha
approved these changes
May 17, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
platosha
marked this pull request as ready for review
May 17, 2022 11:42
vaadin-bot
pushed a commit
that referenced
this pull request
May 17, 2022
…tions (#13725) * Add a parameter to ServerInfo to show the right product name * Add a test to prevent regressions * Comply to formatting conventions
vaadin-bot
pushed a commit
that referenced
this pull request
May 17, 2022
…tions (#13725) * Add a parameter to ServerInfo to show the right product name * Add a test to prevent regressions * Comply to formatting conventions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This patch changes the product name from Vaadin to Hilla when the presence of the
fusion-endpointin the classpath is detected.Fixes vaadin/hilla#356
Type of change
Checklist