Skip to content

Fix: devmode popup will show Hilla instead of Vaadin in Hilla applications - #13725

Merged
platosha merged 5 commits into
masterfrom
fix/hilla-product-name
May 17, 2022
Merged

platosha merged 5 commits into
masterfrom
fix/hilla-product-name

Conversation

@cromoteca

@cromoteca cromoteca commented May 10, 2022 •

Copy link
Copy Markdown
Contributor

Description

This patch changes the product name from Vaadin to Hilla when the presence of the fusion-endpoint in the classpath is detected.

Fixes vaadin/hilla#356

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@CLAassistant

CLAassistant commented May 10, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented May 10, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   966 files  +1     966 suites  +1   48m 49s ⏱️ + 3m 27s
6 275 tests +1  6 227 ✔️ +1  48 💤 ±0  0 ❌ ±0 
6 503 runs  +3  6 449 ✔️ +3  54 💤 ±0  0 ❌ ±0 

Results for commit 2b95f11. ± Comparison against base commit 7bf1f01.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov added hilla Issues related to Hilla labels May 12, 2022
@Artur-

Artur- commented May 12, 2022

Copy link
Copy Markdown
Member

This will need a rebase now that I went and renamed the dev mode gizmo in #13679

@cromoteca

cromoteca commented May 12, 2022 •

Copy link
Copy Markdown
Contributor Author

OK I'll take care of that

@cromoteca
cromoteca marked this pull request as draft May 12, 2022 14:42
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha
platosha marked this pull request as ready for review May 17, 2022 11:42
@platosha
platosha merged commit c6eb8f4 into master May 17, 2022
@platosha
platosha deleted the fix/hilla-product-name branch May 17, 2022 11:43
vaadin-bot pushed a commit that referenced this pull request May 17, 2022
…tions (#13725)

* Add a parameter to ServerInfo to show the right product name

* Add a test to prevent regressions

* Comply to formatting conventions
vaadin-bot pushed a commit that referenced this pull request May 17, 2022
…tions (#13725)

* Add a parameter to ServerInfo to show the right product name

* Add a test to prevent regressions

* Comply to formatting conventions
mshabarov pushed a commit that referenced this pull request May 18, 2022
…tions (#13725) (#13789)

* Add a parameter to ServerInfo to show the right product name

* Add a test to prevent regressions

* Comply to formatting conventions

Co-authored-by: Luciano Vernaschi <cromoteca@users.noreply.github.com>
mshabarov pushed a commit that referenced this pull request May 18, 2022
…tions (#13725) (#13790)

* Add a parameter to ServerInfo to show the right product name

* Add a test to prevent regressions

* Comply to formatting conventions

Co-authored-by: Luciano Vernaschi <cromoteca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devmode popup shows Hilla 1.0 as Vaadin 1.0

6 participants