Skip to content

feat: Support listening to browser unsubscribe in endpoint methods - #13731

Merged
platosha merged 1 commit into
masterfrom
endpointsubscription
May 23, 2022
Merged

platosha merged 1 commit into
masterfrom
endpointsubscription

Conversation

@Artur-

@Artur- Artur- commented May 11, 2022

Copy link
Copy Markdown
Member

Adds support for EndpointSubscription as an endpoint return value
An endpoint subscription is the same as a Flux but in addition supports an unsubscribe event handler, triggered when the client closes the subscription (not when the flux completes or errors)

Fixes vaadin/hilla#403

@Artur- Artur- added hilla Issues related to Hilla target/23.1 labels May 11, 2022
@Artur-
Artur- requested a review from platosha May 11, 2022 07:41
@github-actions

github-actions Bot commented May 11, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   968 files  ±  0     968 suites  ±0   47m 29s ⏱️ - 1m 51s
6 289 tests +  5  6 241 ✔️ +  5  48 💤 ±0  0 ❌ ±0 
6 517 runs  +14  6 463 ✔️ +14  54 💤 ±0  0 ❌ ±0 

Results for commit 0718c89. ± Comparison against base commit 014d4cd.

♻️ This comment has been updated with latest results.

@Artur-
Artur- force-pushed the endpointsubscription branch from f98ad6c to 27e1f01 Compare May 21, 2022 11:42
Adds support for EndpointSubscription as an endpoint return value
An endpoint subscription is the same as a Flux but in addition supports an unsubscribe event handler, triggered when the client closes the subscription (not when the flux completes or errors)

Fixes vaadin/hilla#403
@Artur-
Artur- force-pushed the endpointsubscription branch from 27e1f01 to 0718c89 Compare May 23, 2022 06:00
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha
platosha merged commit ac2d5de into master May 23, 2022
@platosha
platosha deleted the endpointsubscription branch May 23, 2022 08:21
vaadin-bot pushed a commit that referenced this pull request May 23, 2022
…13731)

Adds support for EndpointSubscription as an endpoint return value
An endpoint subscription is the same as a Flux but in addition supports an unsubscribe event handler, triggered when the client closes the subscription (not when the flux completes or errors)

Fixes vaadin/hilla#403
Artur- pushed a commit that referenced this pull request May 23, 2022
…13731) (#13836)

Adds support for EndpointSubscription as an endpoint return value
An endpoint subscription is the same as a Flux but in addition supports an unsubscribe event handler, triggered when the client closes the subscription (not when the flux completes or errors)

Fixes vaadin/hilla#403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to detect in a flux endpoint that a user has disconnected

3 participants