Skip to content

fix: Always get url mapping using helpers when using Spring Boot - #13791

Merged
Artur- merged 3 commits into
masterfrom
read-urlmapping-prop
May 19, 2022
Merged

Artur- merged 3 commits into
masterfrom
read-urlmapping-prop

Conversation

@Artur-

@Artur- Artur- commented May 17, 2022 •

Copy link
Copy Markdown
Member

The properties in application.properties use a relaxed mapping strategy in
Spring Boot so all variants of "url-mapping","urlmapping","urlMapping" are
mapped to the same value in VaadinConfigurationProperties.

Fixes vaadin/spring#478

@github-actions

github-actions Bot commented May 17, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   966 files  +  25     966 suites  +25   47m 16s ⏱️ + 4m 45s
6 275 tests +159  6 227 ✔️ +160  48 💤 ±0  0 ❌ ±0 
6 500 runs  +159  6 446 ✔️ +160  54 💤 ±0  0 ❌ ±0 

Results for commit f86d176. ± Comparison against base commit 6a5710d.

♻️ This comment has been updated with latest results.

@Artur-
Artur- force-pushed the read-urlmapping-prop branch 2 times, most recently from 5508c5e to 5bb5ebc Compare May 17, 2022 14:03
The properties in application.properties use a relaxed mapping strategy in
Spring Boot so all variants of "url-mapping","urlmapping","urlMapping" are
mapped to the same value in VaadinConfigurationProperties.
@Artur-
Artur- force-pushed the read-urlmapping-prop branch from 5bb5ebc to 2d83422 Compare May 17, 2022 18:47
@Artur- Artur- changed the title fix: Check url mapping using various potential property names fix: Always get url mapping using helpers when using Spring Boot May 17, 2022
@Artur-
Artur- enabled auto-merge (squash) May 17, 2022 19:17
@Artur-
Artur- requested a review from mshabarov May 18, 2022 08:55
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur-
Artur- merged commit edfb93f into master May 19, 2022
@Artur-
Artur- deleted the read-urlmapping-prop branch May 19, 2022 06:10
vaadin-bot pushed a commit that referenced this pull request May 19, 2022
)

The properties in application.properties use a relaxed mapping strategy in
Spring Boot so all variants of "url-mapping","urlmapping","urlMapping" are
mapped to the same value in VaadinConfigurationProperties.

Fixes vaadin/spring#478
mshabarov pushed a commit that referenced this pull request May 19, 2022
) (#13803)

The properties in application.properties use a relaxed mapping strategy in
Spring Boot so all variants of "url-mapping","urlmapping","urlMapping" are
mapped to the same value in VaadinConfigurationProperties.

Fixes vaadin/spring#478

Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vaadin Spring] RootMappedCondition not completely working

3 participants