Skip to content

Fix: Use /HILLA/push as the Hilla push endpoint - #13809

Merged
platosha merged 1 commit into
masterfrom
hilla-push-url
May 20, 2022
Merged

platosha merged 1 commit into
masterfrom
hilla-push-url

Conversation

@Artur-

@Artur- Artur- commented May 19, 2022

Copy link
Copy Markdown
Member

This avoids conflict with the VaadinServlet when it is bound to /VAADIN/*

Related to vaadin/hilla#424

This avoids conflict with the VaadinServlet when it is bound to /VAADIN/*

Related to vaadin/hilla#424
@Artur-
Artur- marked this pull request as ready for review May 19, 2022 10:37
@Artur- Artur- added the hilla Issues related to Hilla label May 19, 2022
@Artur-
Artur- requested a review from platosha May 19, 2022 10:37
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented May 19, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   968 files  ±0     968 suites  ±0   52m 41s ⏱️ + 4m 26s
6 280 tests ±0  6 232 ✔️ ±0  48 💤 ±0  0 ❌ ±0 
6 506 runs  ±0  6 452 ✔️ ±0  54 💤 ±0  0 ❌ ±0 

Results for commit 6455af3. ± Comparison against base commit 9c57186.

♻️ This comment has been updated with latest results.

@platosha
platosha merged commit 09b5028 into master May 20, 2022
@platosha
platosha deleted the hilla-push-url branch May 20, 2022 10:27
vaadin-bot pushed a commit that referenced this pull request May 20, 2022
This avoids conflict with the VaadinServlet when it is bound to /VAADIN/*

Related to vaadin/hilla#424
Artur- pushed a commit that referenced this pull request May 21, 2022
This avoids conflict with the VaadinServlet when it is bound to /VAADIN/*

Related to vaadin/hilla#424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants