Repository navigation
fix: Include RouteAliases in RouteNotFoundError message - #13908
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
requested changes
Jun 7, 2022
mshabarov
approved these changes
Jun 7, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
mshabarov
pushed a commit
that referenced
this pull request
Jun 8, 2022
) When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation. Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
mshabarov
pushed a commit
that referenced
this pull request
Jun 8, 2022
) When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation. Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
mshabarov
pushed a commit
that referenced
this pull request
Jun 8, 2022
) When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation. Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
mshabarov
pushed a commit
that referenced
this pull request
Jun 10, 2022
) When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation. Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
taefi
pushed a commit
that referenced
this pull request
Jun 10, 2022
) When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation. Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
ZheSun88
pushed a commit
that referenced
this pull request
Sep 21, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
mshabarov
pushed a commit
that referenced
this pull request
Sep 22, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the
@RouteAliasannotation.This PR fixes this.