Skip to content

fix: Include RouteAliases in RouteNotFoundError message - #13908

Merged
mshabarov merged 3 commits into
masterfrom
alias-routenotfound
Jun 7, 2022
Merged

mshabarov merged 3 commits into
masterfrom
alias-routenotfound

Conversation

@tarekoraby

Copy link
Copy Markdown
Contributor

When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.

This PR fixes this.

@tarekoraby tarekoraby changed the title Include RouteAliases in RouteNotFoundError message fix: Include RouteAliases in RouteNotFoundError message Jun 4, 2022
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

   972 files  +   518     972 suites  +518   49m 7s ⏱️ + 11m 16s
6 302 tests +5 491  6 254 ✔️ +5 483  48 💤 +8  0 ❌ ±0 
6 529 runs  +5 499  6 475 ✔️ +5 491  54 💤 +8  0 ❌ ±0 

Results for commit e0ed749. ± Comparison against base commit 62e1cf8.

@mshabarov mshabarov added the Contribution PRs coming from the community or external to the team label Jun 6, 2022
@mshabarov
mshabarov merged commit 553995a into master Jun 7, 2022
@mshabarov
mshabarov deleted the alias-routenotfound branch June 7, 2022 08:39
vaadin-bot pushed a commit that referenced this pull request Jun 7, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
vaadin-bot pushed a commit that referenced this pull request Jun 7, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
vaadin-bot pushed a commit that referenced this pull request Jun 7, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
mshabarov pushed a commit that referenced this pull request Jun 8, 2022
)

When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
mshabarov pushed a commit that referenced this pull request Jun 8, 2022
)

When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
mshabarov pushed a commit that referenced this pull request Jun 8, 2022
)

When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
mshabarov pushed a commit that referenced this pull request Jun 10, 2022
)

When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
taefi pushed a commit that referenced this pull request Jun 10, 2022
)

When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
ZheSun88 pushed a commit that referenced this pull request Sep 21, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
mshabarov pushed a commit that referenced this pull request Sep 22, 2022
When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants