Skip to content

feat: enable components to notify binder when validation state changes (#13940) (CP: 23.1) - #13993

Merged
mshabarov merged 3 commits into
23.1from
cherry-pick-13940-to-23.1-1655377032171
Jun 17, 2022
Merged

mshabarov merged 3 commits into
23.1from
cherry-pick-13940-to-23.1-1655377032171

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

#13940)

* feat: enable components to notify binder about their validation status changes

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
*
* @see com.vaadin.flow.data.binder.Binder.BindingBuilderImpl#bind(ValueProvider,
* Setter)
* @since 23.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this method is down-ported to anything from 14.x to 23.1.x - this since tag is really weird

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch. @since 2.7 would be better.

@github-actions

github-actions Bot commented Jun 16, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   970 files  +1     970 suites  +1   57m 34s ⏱️ - 3m 32s
6 304 tests +8  6 255 ✔️ +8  49 💤 ±0  0 ❌ ±0 
6 534 runs  +8  6 479 ✔️ +8  55 💤 ±0  0 ❌ ±0 

Results for commit 99efd30. ± Comparison against base commit 00791b2.

♻️ This comment has been updated with latest results.

@mshabarov
mshabarov enabled auto-merge (squash) June 17, 2022 06:07
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov
mshabarov merged commit e606d94 into 23.1 Jun 17, 2022
@mshabarov
mshabarov deleted the cherry-pick-13940-to-23.1-1655377032171 branch June 17, 2022 06:25
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants