Repository navigation
feat: swallow exceptions on unparseable NPM package versions - #14233
Merged
Merged
Conversation
cromoteca
marked this pull request as draft
July 29, 2022 09:16
Contributor
Collaborator
|
We discussed internally and choose to handle two try/catch statements.
I'll take care of this changes as soon of possible |
Contributor
Author
OK. In the meanwhile, I got the |
mcollovati
reviewed
Aug 2, 2022
Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati
approved these changes
Aug 2, 2022
mcollovati
enabled auto-merge (squash)
August 2, 2022 07:59
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








When checking for new NPM package versions, let's skip all versions that we do not understand.
Closes #14217