Skip to content

fix: support import without url keyword in theme generator (#14234) (CP: 23.1) - #14243

Merged
mshabarov merged 1 commit into
23.1from
cherry-pick-14234-to-23.1-1659339934031
Aug 1, 2022
Merged

mshabarov merged 1 commit into
23.1from
cherry-pick-14234-to-23.1-1659339934031

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

With Vite it may happend that '@import url(...)' in CSS are rewritten
as '@import ...', that is a valid CSS statement.
Currently the theme generator does not handle the case and this prevents
the resource to be added to the head section. A warning is also
logged on browser console, stating import rules not allowed when
creating stylesheets.
This change updates the importMatcher regex to handle @import without url
@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions

github-actions Bot commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

   972 files  +  27     972 suites  +27   59m 18s ⏱️ - 3m 40s
6 324 tests +161  6 275 ✔️ +162  49 💤 ±0  0 ❌ ±0 
6 552 runs  +162  6 497 ✔️ +163  55 💤 ±0  0 ❌ ±0 

Results for commit d91744f. ± Comparison against base commit be28afc.

@mshabarov
mshabarov merged commit 2c44d33 into 23.1 Aug 1, 2022
@mshabarov
mshabarov deleted the cherry-pick-14234-to-23.1-1659339934031 branch August 1, 2022 08:19
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants