Skip to content

fix: handle theme files creation and deletion with Vite (#14260) (CP: 23.1) - #14262

Merged
mcollovati merged 1 commit into
23.1from
cherry-pick-14260-to-23.1-1659536012541
Aug 4, 2022
Merged

mcollovati merged 1 commit into
23.1from
cherry-pick-14260-to-23.1-1659536012541

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Vite 'handleHotUpdate' hook is invoked only for file changes, not for creation nor deletion.
This change adds a watcher as well for those events and triggers theme regeneration
when theme file are added or deleted

Fixes #12154
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions

github-actions Bot commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

   972 files  ±0     972 suites  ±0   59m 40s ⏱️ - 1m 16s
6 323 tests ±0  6 274 ✔️ ±0  49 💤 ±0  0 ❌ ±0 
6 551 runs  +3  6 496 ✔️ +3  55 💤 ±0  0 ❌ ±0 

Results for commit 37a1365. ± Comparison against base commit 7b64c96.

@mcollovati
mcollovati merged commit 7bce822 into 23.1 Aug 4, 2022
@mcollovati
mcollovati deleted the cherry-pick-14260-to-23.1-1659536012541 branch August 4, 2022 06:08
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants