Skip to content

fix: regenerate theme files if not existing during Vite resolution - #14307

Merged
mshabarov merged 1 commit into
masterfrom
fix/theme_regeneration_on_themejs_missing_deps
Aug 10, 2022
Merged

mshabarov merged 1 commit into
masterfrom
fix/theme_regeneration_on_themejs_missing_deps

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

It may happen that when Vite analyses imports for theme.js file,
they are not yet generated of filesystem and this make compilation
fail.
This change checks for theme.js imports existence, and if not present
forces theme generation process

Should fix ThemeSwitchLiveReloadIT flakiness

It may happen that when Vite analyses imports for theme.js file,
they are not yet generated of filesystem and this make compilation
fail.
This change checks for theme.js imports existence, and if not present
forces theme generation process
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati
mcollovati requested a review from mshabarov August 10, 2022 09:29
@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   917 files  ±0     917 suites  ±0   52m 2s ⏱️ -26s
6 008 tests ±0  5 954 ✔️ ±0  54 💤 ±0  0 ❌ ±0 
6 221 runs   - 2  6 159 ✔️  - 2  62 💤 ±0  0 ❌ ±0 

Results for commit 3dc9e61. ± Comparison against base commit fccffb2.

@mshabarov
mshabarov merged commit 1d604ad into master Aug 10, 2022
@mshabarov
mshabarov deleted the fix/theme_regeneration_on_themejs_missing_deps branch August 10, 2022 09:47
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants