Repository navigation
fix: Request Desktop Site feature with only MajorVersion - #14322
Merged
Merged
Conversation
Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
Contributor
taefi
reviewed
Aug 11, 2022
Comment on lines
+317
to
+320
| private static int getVersionStringLength(String userAgent, int i) { | ||
| int versionBreak = userAgent.substring(i).indexOf(" "); | ||
| if (versionBreak == -1) { | ||
| versionBreak = userAgent.substring(i).length(); |
Contributor
There was a problem hiding this comment.
Suggested change
| private static int getVersionStringLength(String userAgent, int i) { | |
| int versionBreak = userAgent.substring(i).indexOf(" "); | |
| if (versionBreak == -1) { | |
| versionBreak = userAgent.substring(i).length(); | |
| private static int getVersionStringLength(String userAgent, int versionIdx) { | |
| int versionBreak = userAgent.substring(versionIdx).indexOf(" "); | |
| if (versionBreak == -1) { | |
| versionBreak = userAgent.substring(versionIdx).length(); |
taefi
reviewed
Aug 11, 2022
| int versionBreak = getVersionStringLength(userAgent, i); | ||
| parseVersionString(safeSubstring(userAgent, i, i + versionBreak)); | ||
| } else { | ||
| i += 7; |
Contributor
There was a problem hiding this comment.
Although it is not part of the changes here, just asking out of curiosity, is this i += 7; happens due to the " crios/".length()?
If so, as an additional improvement, I suggest defining a constant or a final local variable for " crios/" and using its length instead of the literal value of 7.
Contributor
Author
There was a problem hiding this comment.
removed one more magic number.
taefi
approved these changes
Aug 11, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
taefi
enabled auto-merge (squash)
August 11, 2022 12:06
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* fix: Request Desktop Site feature with only MajorVersion Fixes User Agent in Chrome for iOS when the Request Desktop Site feature is enabled. At this time the version only consists of the major version. part of #13921
Collaborator
|
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes User Agent in Chrome for iOS when the
Request Desktop Site feature is enabled.
At this time the version only consists of the major version.
part of #13921