Skip to content

fix: initialize PwaHandler only once (#14390) (CP: 23.1) - #14398

Merged
mcollovati merged 1 commit into
23.1from
cherry-pick-14390-to-23.1-1660916708734
Aug 19, 2022
Merged

mcollovati merged 1 commit into
23.1from
cherry-pick-14390-to-23.1-1660916708734

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

* fix: initialized PWAHandler only once

PwaHandler has an isInitialized flag that is checked on handleRequest method,
but never initialized, causing init method to be invoked on every request.
This change sets the flag within init method.
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   973 files  ±0     973 suites  ±0   1h 5m 31s ⏱️ +6s
6 329 tests +1  6 280 ✔️ +1  49 💤 ±0  0 ❌ ±0 
6 558 runs  +3  6 503 ✔️ +3  55 💤 ±0  0 ❌ ±0 

Results for commit da44726. ± Comparison against base commit 04f5d32.

@mcollovati
mcollovati merged commit d40fa61 into 23.1 Aug 19, 2022
@mcollovati
mcollovati deleted the cherry-pick-14390-to-23.1-1660916708734 branch August 19, 2022 15:16
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants