Skip to content

feat: Give an access to ViewAccessChecker in subclasses - #14402

Merged
taefi merged 2 commits into
masterfrom
view-access-checker-getter
Aug 22, 2022
Merged

taefi merged 2 commits into
masterfrom
view-access-checker-getter

Conversation

@mshabarov

Copy link
Copy Markdown
Contributor

Makes ViewAccessChecker be accessible in the VaadinWebSecurity subclasses,
for example, to be able to override the security configuration for SSO.

Makes ViewAccessChecker be accessible in the VaadinWebSecurity subclasses,
for example, to be able to override the security configuration for SSO.
@mshabarov
mshabarov requested a review from taefi August 22, 2022 07:55
* @return {@link ViewAccessChecker} bean used by this VaadinWebSecurity
* configuration.
*/
protected ViewAccessChecker getViewAccessChecker() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't you just @Autowire it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be an option as well. But with having a getter, you can avoid an extra code in your implementation class.

@github-actions

github-actions Bot commented Aug 22, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   918 files  ±  0     918 suites  ±0   51m 23s ⏱️ - 1m 50s
6 021 tests ±  0  5 968 ✔️ ±  0  53 💤 ±0  0 ❌ ±0 
6 230 runs   - 16  6 170 ✔️  - 16  60 💤 ±0  0 ❌ ±0 

Results for commit 9d2c251. ± Comparison against base commit 451f7ef.

♻️ This comment has been updated with latest results.

@taefi
taefi enabled auto-merge (squash) August 22, 2022 10:07
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@taefi
taefi merged commit 3d526a2 into master Aug 22, 2022
@taefi
taefi deleted the view-access-checker-getter branch August 22, 2022 10:39
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.beta3 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants