Repository navigation
feat: Give an access to ViewAccessChecker in subclasses - #14402
Merged
Merged
Conversation
Makes ViewAccessChecker be accessible in the VaadinWebSecurity subclasses, for example, to be able to override the security configuration for SSO.
Artur-
reviewed
Aug 22, 2022
| * @return {@link ViewAccessChecker} bean used by this VaadinWebSecurity | ||
| * configuration. | ||
| */ | ||
| protected ViewAccessChecker getViewAccessChecker() { |
Member
There was a problem hiding this comment.
Why wouldn't you just @Autowire it?
Contributor
Author
There was a problem hiding this comment.
Can be an option as well. But with having a getter, you can avoid an extra code in your implementation class.
Contributor
taefi
approved these changes
Aug 22, 2022
taefi
enabled auto-merge (squash)
August 22, 2022 10:07
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 23.2.0.beta3 and is also targeting the upcoming stable 23.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Makes ViewAccessChecker be accessible in the VaadinWebSecurity subclasses,
for example, to be able to override the security configuration for SSO.