Skip to content

fix: Not modify browser history if location has no hash (#14397) (CP: 23.1) - #14404

Merged
taefi merged 1 commit into
23.1from
cherry-pick-14397-to-23.1-1661162577879
Aug 22, 2022
Merged

taefi merged 1 commit into
23.1from
cherry-pick-14397-to-23.1-1661162577879

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Fixes the hashed segment removal logic:
if no segment with hash is present in the location,
while navigating between Flow and legacy views/components,
the update of the browser history is not needed.

Fixes vaadin/multiplatform-runtime#115
@taefi
taefi enabled auto-merge (squash) August 22, 2022 10:09
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   973 files  ±0     973 suites  ±0   1h 6m 39s ⏱️ + 2m 53s
6 330 tests +1  6 281 ✔️ +1  49 💤 ±0  0 ❌ ±0 
6 554 runs   - 1  6 499 ✔️  - 1  55 💤 ±0  0 ❌ ±0 

Results for commit b260454. ± Comparison against base commit d40fa61.

@taefi
taefi merged commit 21e6ea7 into 23.1 Aug 22, 2022
@taefi
taefi deleted the cherry-pick-14397-to-23.1-1661162577879 branch August 22, 2022 10:39
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants