Skip to content

fix: Not modify browser history if location has no hash (#14397) (CP: 9.0) - #14406

Merged
taefi merged 1 commit into
9.0from
cherry-pick-14397-to-9.0-1661162600965
Aug 22, 2022
Merged

taefi merged 1 commit into
9.0from
cherry-pick-14397-to-9.0-1661162600965

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Fixes the hashed segment removal logic:
if no segment with hash is present in the location,
while navigating between Flow and legacy views/components,
the update of the browser history is not needed.

Fixes vaadin/multiplatform-runtime#115
@taefi
taefi enabled auto-merge (squash) August 22, 2022 10:09
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   774 files  ±0     774 suites  ±0   26m 27s ⏱️ +59s
5 766 tests +1  5 714 ✔️ +1  52 💤 ±0  0 ❌ ±0 
5 811 runs   - 2  5 758 ✔️  - 2  53 💤 ±0  0 ❌ ±0 

Results for commit c0cfbbe. ± Comparison against base commit 967f9fe.

@taefi
taefi merged commit f31cf9a into 9.0 Aug 22, 2022
@taefi
taefi deleted the cherry-pick-14397-to-9.0-1661162600965 branch August 22, 2022 11:14
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 22.0.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants