Skip to content

fix: Do not use a fixed download root (#14632) - #14703

Merged
mshabarov merged 1 commit into
9.0from
cherry/cherrypick-14632-to-9.0
Sep 30, 2022
Merged

mshabarov merged 1 commit into
9.0from
cherry/cherrypick-14632-to-9.0

Conversation

@caalador

Copy link
Copy Markdown
Contributor

As the default download root might be
different depending on the used system
we should not use a hardcoded default if
user has not given a download root.

Fixes #13837

@sonatype-lift

sonatype-lift Bot commented Sep 30, 2022

Copy link
Copy Markdown

⚠️ 81 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@github-actions

github-actions Bot commented Sep 30, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   776 files  ±0     776 suites  ±0   24m 1s ⏱️ - 2m 5s
5 767 tests ±0  5 716 ✔️ +1  51 💤  - 1  0 ❌ ±0 
5 818 runs  ±0  5 766 ✔️ +1  52 💤  - 1  0 ❌ ±0 

Results for commit c8cf9a8. ± Comparison against base commit 3257019.

♻️ This comment has been updated with latest results.

As the default download root might be
different depending on the used system
we should not use a hardcoded default if
user has not given a download root.

Fixes #13837
@caalador
caalador force-pushed the cherry/cherrypick-14632-to-9.0 branch from ba04157 to c8cf9a8 Compare September 30, 2022 04:46
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mshabarov
mshabarov merged commit 09019d4 into 9.0 Sep 30, 2022
@mshabarov
mshabarov deleted the cherry/cherrypick-14632-to-9.0 branch September 30, 2022 07:24
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 22.0.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants