Skip to content

fix: attach polymer binding callback to a promise that always resolves (#14729) (CP: 23.2) - #14754

Merged
ZheSun88 merged 1 commit into
23.2from
cherry-pick-14729-to-23.2-1665130440478
Oct 7, 2022
Merged

ZheSun88 merged 1 commit into
23.2from
cherry-pick-14729-to-23.2-1665130440478

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

#14729)

Polymer binding callback was attached to the promise returned by
customElements.whenDefined, but this promise may never complete
if the input element is not a custom element, causing memory leaks
on browser because of element capture.
This change introduces a new promise that completes either when
whenDefined is fulfilled or after a fixed timeout, allowing
the garbage collector to clean resources.

Fixes #14422
@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

   929 files  ±0     929 suites  ±0   57m 5s ⏱️ + 1m 21s
6 054 tests ±0  6 000 ✔️ ±0  54 💤 ±0  0 ❌ ±0 
6 286 runs  +1  6 225 ✔️ +1  61 💤 ±0  0 ❌ ±0 

Results for commit 99fe9a0. ± Comparison against base commit 6720415.

@ZheSun88
ZheSun88 merged commit 3eef1b0 into 23.2 Oct 7, 2022
@ZheSun88
ZheSun88 deleted the cherry-pick-14729-to-23.2-1665130440478 branch October 7, 2022 09:32
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants