Repository navigation
feat!: Enable license checking for flow-polymer-template - #15138
Merged
Merged
Conversation
Contributor
vursen
marked this pull request as ready for review
November 16, 2022 13:50
mshabarov
requested changes
Nov 17, 2022
vursen
force-pushed
the
add-license-check-for-polymer-template
branch
from
November 17, 2022 13:02
a384928 to
0a020c4
Compare
mshabarov
previously approved these changes
Nov 17, 2022
vursen
commented
Nov 17, 2022
…polymertemplate/PolymerTemplate.java
mshabarov
previously approved these changes
Nov 17, 2022
Artur-
requested changes
Nov 17, 2022
| UsageStatistics.markAsUsed("flow/PolymerTemplate", null); | ||
|
|
||
| Properties properties = new Properties(); | ||
| try { |
Member
There was a problem hiding this comment.
We do not need a separate version.properties for this module. It is fine to use com.vaadin.flow.server.Version
Contributor
Author
There was a problem hiding this comment.
Good point. Let me update the PR.
Artur-
reviewed
Nov 17, 2022
| </dependency> | ||
| </dependencies> | ||
| <build> | ||
| <resources> |
Member
There was a problem hiding this comment.
This also becomes unnecessary is using flow-server Version
mshabarov
approved these changes
Nov 18, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Artur-
approved these changes
Nov 18, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha4 and is also targeting the upcoming stable 24.0.0 version. |
MarcinVaadin
pushed a commit
that referenced
this pull request
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The PR enables license checking for the
flow-polymer-templatemodule as, starting with Vaadin 24, it is only available for Prime+ customers.Fixes #15137
Type of change
Checklist