Skip to content

feat!: Enable license checking for flow-polymer-template - #15138

Merged
Artur- merged 15 commits into
masterfrom
add-license-check-for-polymer-template
Nov 18, 2022
Merged

Artur- merged 15 commits into
masterfrom
add-license-check-for-polymer-template

Conversation

@vursen

@vursen vursen commented Nov 15, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR enables license checking for the flow-polymer-template module as, starting with Vaadin 24, it is only available for Prime+ customers.

Fixes #15137

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@github-actions

github-actions Bot commented Nov 15, 2022 •

Copy link
Copy Markdown
Contributor

Unit Test Results

   957 files  ±0     957 suites  ±0   55m 31s ⏱️ + 1m 11s
6 114 tests ±0  6 061 ✔️ ±0  53 💤 ±0  0 ❌ ±0 
6 374 runs   - 5  6 313 ✔️  - 5  61 💤 ±0  0 ❌ ±0 

Results for commit 1ed40e1. ± Comparison against base commit d846c8b.

♻️ This comment has been updated with latest results.

@vursen vursen changed the title feat!: check license for flow-polymer-template (WIP) feat!: check flow-polymer-template for a license (WIP) Nov 16, 2022
@vursen vursen changed the title feat!: check flow-polymer-template for a license (WIP) feat!: add license checking for flow-polymer-template (WIP) Nov 16, 2022
@vursen vursen changed the title feat!: add license checking for flow-polymer-template (WIP) feat!: add license checking to flow-polymer-template (WIP) Nov 16, 2022
@vursen vursen changed the title feat!: add license checking to flow-polymer-template (WIP) feat!: Add license checking to flow-polymer-template Nov 16, 2022
@vursen
vursen marked this pull request as ready for review November 16, 2022 13:50
@vursen vursen changed the title feat!: Add license checking to flow-polymer-template feat!: Enable license checking for flow-polymer-template Nov 17, 2022
@mshabarov
mshabarov requested a review from Artur- November 17, 2022 12:05
@vursen
vursen force-pushed the add-license-check-for-polymer-template branch from a384928 to 0a020c4 Compare November 17, 2022 13:02
@vursen
vursen requested a review from mshabarov November 17, 2022 13:17
mshabarov
mshabarov previously approved these changes Nov 17, 2022
mshabarov
mshabarov previously approved these changes Nov 17, 2022
UsageStatistics.markAsUsed("flow/PolymerTemplate", null);

Properties properties = new Properties();
try {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need a separate version.properties for this module. It is fine to use com.vaadin.flow.server.Version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Let me update the PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread flow-polymer-template/pom.xml Outdated
</dependency>
</dependencies>
<build>
<resources>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also becomes unnecessary is using flow-server Version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Nov 18, 2022
@vursen
vursen requested a review from Artur- November 18, 2022 12:31
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur-
Artur- merged commit b1d51a8 into master Nov 18, 2022
@Artur-
Artur- deleted the add-license-check-for-polymer-template branch November 18, 2022 14:12
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha4 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a license to polymer module in Flow

4 participants