Skip to content

feat: add refresh flag to navigation event (#15324) (CP: 23.3) - #15331

Merged
mcollovati merged 1 commit into
23.3from
cherry-pick-15324-to-23.3-1669879561996
Dec 1, 2022
Merged

mcollovati merged 1 commit into
23.3from
cherry-pick-15324-to-23.3-1669879561996

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Add the isRefreshEvent to BeforeEnterEvent
and AfterNavigationEvent to be make it possible
to distinguish if the event is for a refresh of
a preserve on refresh view.

Fixes #14999
@sonarqubecloud

sonarqubecloud Bot commented Dec 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

   954 files  ±0     954 suites  ±0   1h 0m 12s ⏱️ -39s
6 094 tests +1  6 041 ✔️ +1  53 💤 ±0  0 ❌ ±0 
6 356 runs  +2  6 295 ✔️ +2  61 💤 ±0  0 ❌ ±0 

Results for commit 720a0ab. ± Comparison against base commit 92d3977.

@mcollovati
mcollovati merged commit 9cb6104 into 23.3 Dec 1, 2022
@mcollovati
mcollovati deleted the cherry-pick-15324-to-23.3-1669879561996 branch December 1, 2022 10:47
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 23.3.0.beta2 and is also targeting the upcoming stable 23.3.0 version.

mcollovati added a commit that referenced this pull request Jul 24, 2024
Programmatic self navigation with query parameters on view with preserve on
refresh do not update the URL in the browser.
This change fixes the regression introduced by #15331, updating push
history also for navigation events with trigger REFRESH.

Fixes #19701
mcollovati added a commit that referenced this pull request Jul 24, 2024
Programmatic self navigation with query parameters on view with preserve on
refresh do not update the URL in the browser.
This change fixes the regression introduced by #15331, updating push
history also for navigation events with trigger REFRESH.

Fixes #19701
vaadin-bot pushed a commit that referenced this pull request Jul 24, 2024
Programmatic self navigation with query parameters on view with preserve on
refresh do not update the URL in the browser.
This change fixes the regression introduced by #15331, updating push
history also for navigation events with trigger REFRESH.

Fixes #19701
vaadin-bot pushed a commit that referenced this pull request Jul 24, 2024
Programmatic self navigation with query parameters on view with preserve on
refresh do not update the URL in the browser.
This change fixes the regression introduced by #15331, updating push
history also for navigation events with trigger REFRESH.

Fixes #19701
vaadin-bot added a commit that referenced this pull request Jul 24, 2024
…P: 24.4) (#19719)

* fix: update browser URL on preserve on refresh navigation (#19718)

Programmatic self navigation with query parameters on view with preserve on
refresh do not update the URL in the browser.
This change fixes the regression introduced by #15331, updating push
history also for navigation events with trigger REFRESH.

Fixes #19701

* restore removed imports

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jul 24, 2024
…P: 24.3) (#19720)

* fix: update browser URL on preserve on refresh navigation (#19718)

Programmatic self navigation with query parameters on view with preserve on
refresh do not update the URL in the browser.
This change fixes the regression introduced by #15331, updating push
history also for navigation events with trigger REFRESH.

Fixes #19701

* restore removed imports

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants