Repository navigation
feat: add refresh flag to navigation event (#15324) (CP: 23.3) - #15331
Merged
Merged
Conversation
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999
|
Kudos, SonarCloud Quality Gate passed!
|
mcollovati
approved these changes
Dec 1, 2022
Collaborator
Author
|
This ticket/PR has been released with Vaadin 23.3.0.beta2 and is also targeting the upcoming stable 23.3.0 version. |
5 of 9 tasks
vaadin-bot
added a commit
that referenced
this pull request
Jul 24, 2024
…P: 24.4) (#19719) * fix: update browser URL on preserve on refresh navigation (#19718) Programmatic self navigation with query parameters on view with preserve on refresh do not update the URL in the browser. This change fixes the regression introduced by #15331, updating push history also for navigation events with trigger REFRESH. Fixes #19701 * restore removed imports --------- Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Jul 24, 2024
…P: 24.3) (#19720) * fix: update browser URL on preserve on refresh navigation (#19718) Programmatic self navigation with query parameters on view with preserve on refresh do not update the URL in the browser. This change fixes the regression introduced by #15331, updating push history also for navigation events with trigger REFRESH. Fixes #19701 * restore removed imports --------- Co-authored-by: Marco Collovati <marco@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








No description provided.