Skip to content

fix: Use root servlet mapping for push url in OSGi case - #15351

Merged
mshabarov merged 4 commits into
masterfrom
handle-osgi-case2
Dec 5, 2022
Merged

mshabarov merged 4 commits into
masterfrom
handle-osgi-case2

Conversation

@mshabarov

@mshabarov mshabarov commented Dec 2, 2022 •

Copy link
Copy Markdown
Contributor

Fallback to a root mapping for push in case if not servlet registration is available (OSGi runtime).

@mshabarov
mshabarov requested a review from tepi December 2, 2022 14:50
@github-actions

github-actions Bot commented Dec 2, 2022 •

Copy link
Copy Markdown
Contributor

Test Results

   939 files  ±0     939 suites  ±0   52m 54s ⏱️ - 3m 19s
5 931 tests ±0  5 885 ✔️  - 1  46 💤 +1  0 ❌ ±0 
6 190 runs  +1  6 137 ✔️  - 3  53 💤 +4  0 ❌ ±0 

Results for commit 2915b78. ± Comparison against base commit 454276f.

♻️ This comment has been updated with latest results.

findFirstUrlMapping(servletRegistration.get())
+ Constants.PUSH_MAPPING);
} else {
getLogger().warn(

@knoobie knoobie Dec 2, 2022 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be info? Now every start of an OSGI deployment would log this warning and the developer has no way to fix it 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Indeed, info or even a debug level would be better. Thanks!

@sonarqubecloud

sonarqubecloud Bot commented Dec 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version.

MarcinVaadin pushed a commit that referenced this pull request Dec 21, 2022
Fallback to a root mapping for push in case if not servlet registration is available (OSGi runtime).

Related-to #14641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants