Repository navigation
fix: Use root servlet mapping for push url in OSGi case - #15351
Merged
Merged
Conversation
Contributor
knoobie
reviewed
Dec 2, 2022
| findFirstUrlMapping(servletRegistration.get()) | ||
| + Constants.PUSH_MAPPING); | ||
| } else { | ||
| getLogger().warn( |
Contributor
There was a problem hiding this comment.
Should this be info? Now every start of an OSGI deployment would log this warning and the developer has no way to fix it 😅
Contributor
Author
There was a problem hiding this comment.
Good point! Indeed, info or even a debug level would be better. Thanks!
|
Kudos, SonarCloud Quality Gate passed! |
mcollovati
approved these changes
Dec 5, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version. |
MarcinVaadin
pushed a commit
that referenced
this pull request
Dec 21, 2022
Fallback to a root mapping for push in case if not servlet registration is available (OSGi runtime). Related-to #14641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fallback to a root mapping for push in case if not servlet registration is available (OSGi runtime).