Skip to content

fix: Vite production build errors with transitive dependencies - #15413

Merged
platosha merged 1 commit into
masterfrom
fix/15395
Dec 9, 2022
Merged

platosha merged 1 commit into
masterfrom
fix/15395

Conversation

@platosha

@platosha platosha commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

Fixes #15395

Modifies the Vite stats.json plugin so that only direct dependencies are considered in npmModules, assuming that transitive dependency versions are not relevant.

In addition, includes integration testing setup up with a transitive dependency for Vite, in both development and production modes.

Fixes #15395

Modifies the Vite stats.json plugin so that only direct dependencies are considered in `npmModules`, assuming that transitive dependency versions are not relevant.

In addition, includes integration testing setup up with a transitive dependency for Vite, in both development and production modes.
@platosha platosha added the hilla Issues related to Hilla label Dec 8, 2022
@platosha
platosha requested a review from Artur- December 8, 2022 14:51
@sonarqubecloud

sonarqubecloud Bot commented Dec 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

github-actions Bot commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

Test Results

   943 files  +1     943 suites  +1   54m 26s ⏱️ + 3m 9s
5 937 tests ±0  5 899 ✔️  - 1  38 💤 +1  0 ❌ ±0 
6 201 runs  +3  6 156 ✔️ +2  45 💤 +1  0 ❌ ±0 

Results for commit baaa112. ± Comparison against base commit 9cb3365.

@Artur-

Artur- commented Dec 8, 2022

Copy link
Copy Markdown
Member

Did you prove here that the postinstall scripts are pointless as there is nothing that tests that they are not run?

@platosha

platosha commented Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

Did you prove here that the postinstall scripts are pointless as there is nothing that tests that they are not run?

Kind of, I found nothing for these particular dependency packages.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version.

MarcinVaadin pushed a commit that referenced this pull request Dec 21, 2022
Fixes #15395

Modifies the Vite stats.json plugin so that only direct dependencies are considered in `npmModules`, assuming that transitive dependency versions are not relevant.

In addition, includes integration testing setup up with a transitive dependency for Vite, in both development and production modes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when discovering transitive package version for stats.json

3 participants