Repository navigation
Conversation
Fixes #15395 Modifies the Vite stats.json plugin so that only direct dependencies are considered in `npmModules`, assuming that transitive dependency versions are not relevant. In addition, includes integration testing setup up with a transitive dependency for Vite, in both development and production modes.
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
Did you prove here that the postinstall scripts are pointless as there is nothing that tests that they are not run? |
Artur-
approved these changes
Dec 8, 2022
Contributor
Author
Kind of, I found nothing for these particular dependency packages. |
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version. |
MarcinVaadin
pushed a commit
that referenced
this pull request
Dec 21, 2022
Fixes #15395 Modifies the Vite stats.json plugin so that only direct dependencies are considered in `npmModules`, assuming that transitive dependency versions are not relevant. In addition, includes integration testing setup up with a transitive dependency for Vite, in both development and production modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #15395
Modifies the Vite stats.json plugin so that only direct dependencies are considered in
npmModules, assuming that transitive dependency versions are not relevant.In addition, includes integration testing setup up with a transitive dependency for Vite, in both development and production modes.