Repository navigation
fix: Don't generate frontend files with devBundle - #15646
Merged
Merged
Conversation
Contributor
caalador
force-pushed
the
issues/15640-frontend-files
branch
from
January 9, 2023 13:06
3529ec7 to
f391290
Compare
caalador
marked this pull request as ready for review
January 9, 2023 13:32
If running application using devBundle do not generate frontend files like, package.json, vite.*.ts etc. Closes #15640
caalador
force-pushed
the
issues/15640-frontend-files
branch
from
January 9, 2023 13:32
f391290 to
8bdbb16
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
reviewed
Jan 10, 2023
| addGenerateTsConfigTask(options); | ||
|
|
||
| if (options.productionMode || options.isEnableDevServer() | ||
| || options.isDevBundleBuild()) { |
Contributor
There was a problem hiding this comment.
isDevBundleBuild() method name makes me doubt if it signals that the express build mode is ON or the Flow is going to build a new dev bundle. I know the right answer, but maybe we could change the name in the future :)
mshabarov
approved these changes
Jan 10, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








If running application using devBundle
do not generate frontend files like,
package.json, vite.*.ts etc.
Closes #15640