Skip to content

fix: Don't generate frontend files with devBundle - #15646

Merged
mshabarov merged 1 commit into
masterfrom
issues/15640-frontend-files
Jan 10, 2023
Merged

mshabarov merged 1 commit into
masterfrom
issues/15640-frontend-files

Conversation

@caalador

@caalador caalador commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

If running application using devBundle
do not generate frontend files like,
package.json, vite.*.ts etc.

Closes #15640

@github-actions

github-actions Bot commented Jan 9, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   937 files  ±0     937 suites  ±0   1h 2m 58s ⏱️ + 1m 59s
5 867 tests ±0  5 832 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 121 runs   - 1  6 079 ✔️  - 1  42 💤 ±0  0 ❌ ±0 

Results for commit 8bdbb16. ± Comparison against base commit 8e474a9.

♻️ This comment has been updated with latest results.

@caalador
caalador force-pushed the issues/15640-frontend-files branch from 3529ec7 to f391290 Compare January 9, 2023 13:06
@caalador
caalador marked this pull request as ready for review January 9, 2023 13:32
If running application using devBundle
do not generate frontend files like,
package.json, vite.*.ts etc.

Closes #15640
@caalador
caalador force-pushed the issues/15640-frontend-files branch from f391290 to 8bdbb16 Compare January 9, 2023 13:32
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Jan 9, 2023
@sonarqubecloud

sonarqubecloud Bot commented Jan 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

addGenerateTsConfigTask(options);

if (options.productionMode || options.isEnableDevServer()
|| options.isDevBundleBuild()) {

@mshabarov mshabarov Jan 10, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDevBundleBuild() method name makes me doubt if it signals that the express build mode is ON or the Flow is going to build a new dev bundle. I know the right answer, but maybe we could change the name in the future :)

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If using express bundle, do not generate frontend files

3 participants