Repository navigation
fix: avoid infinite recursion on imported directories (#15596) (CP: 9.0) - #15715
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -624,8 +633,13 @@ private void handleImports(String path, AbstractTheme theme, | |||
| */ | |||
| private String resolve(String importedPath, Path moduleFile, String path) { | |||
| String pathPrefix = moduleFile.toString(); | |||
There was a problem hiding this comment.
💬 2 similar findings have been found in this PR
Var: Non-constant variable missing @var annotation
| String pathPrefix = moduleFile.toString(); | |
| @Var String pathPrefix = moduleFile.toString(); |
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| flow-server/src/main/java/com/vaadin/flow/server/frontend/AbstractUpdateImports.java | 644 |
| flow-server/src/main/java/com/vaadin/flow/server/frontend/AbstractUpdateImports.java | 636 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
@sonatype-lift ignore
There was a problem hiding this comment.
I've recorded these 3 issues as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/15715.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/15715.diff | git applyOnce you're satisfied commit and push your changes in your project. Footnotes |
|
This ticket/PR has been released with Vaadin 22.0.28. |








Fixes #15595