Skip to content

fix: avoid infinite recursion on imported directories (#15596) (CP: 9.0) - #15715

Merged
mcollovati merged 1 commit into
9.0from
cherry/cherrypick-15596-to-9.0
Jan 20, 2023
Merged

mcollovati merged 1 commit into
9.0from
cherry/cherrypick-15596-to-9.0

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

Fixes #15595

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -624,8 +633,13 @@ private void handleImports(String path, AbstractTheme theme,
*/
private String resolve(String importedPath, Path moduleFile, String path) {
String pathPrefix = moduleFile.toString();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0% of developers fix this issue

💬 2 similar findings have been found in this PR


Var: Non-constant variable missing @var annotation


Suggested change
String pathPrefix = moduleFile.toString();
@Var String pathPrefix = moduleFile.toString();

🔎 Expand here to view all instances of this finding
File Path Line Number
flow-server/src/main/java/com/vaadin/flow/server/frontend/AbstractUpdateImports.java 644
flow-server/src/main/java/com/vaadin/flow/server/frontend/AbstractUpdateImports.java 636

Visit the Lift Web Console to find more details in your report.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonatype-lift ignore

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recorded these 3 issues as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

@sonatype-lift

sonatype-lift Bot commented Jan 19, 2023

Copy link
Copy Markdown

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/15715.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/15715.diff | git apply

Once you're satisfied commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser. ↩

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

   780 files  ±0     780 suites  ±0   29m 32s ⏱️ +17s
5 790 tests +2  5 738 ✔️ +1  52 💤 +1  0 ❌ ±0 
5 839 runs  +8  5 786 ✔️ +7  53 💤 +1  0 ❌ ±0 

Results for commit 0df12b2. ± Comparison against base commit cc4f588.

@mcollovati
mcollovati merged commit 2022119 into 9.0 Jan 20, 2023
@mcollovati
mcollovati deleted the cherry/cherrypick-15596-to-9.0 branch January 20, 2023 09:35
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 22.0.28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants