Skip to content

feat: Allow smooth scrolling a component into view - #15735

Merged
mcollovati merged 5 commits into
masterfrom
scroll-into-smooth
Jan 23, 2023
Merged

mcollovati merged 5 commits into
masterfrom
scroll-into-smooth

Conversation

@Artur-

@Artur- Artur- commented Jan 20, 2023

Copy link
Copy Markdown
Member

No description provided.

@Artur- Artur- changed the title feat: Allow smooth scrolling an element into view feat: Allow smooth scrolling a component into view Jan 20, 2023
@github-actions

github-actions Bot commented Jan 20, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   940 files  ±0     940 suites  ±0   53m 52s ⏱️ + 1m 9s
5 886 tests +3  5 851 ✔️ +3  35 💤 ±0  0 ❌ ±0 
6 131 runs  +4  6 089 ✔️ +4  42 💤 ±0  0 ❌ ±0 

Results for commit 1c8ffbc. ± Comparison against base commit 3b2c3ea.

♻️ This comment has been updated with latest results.

@sonatype-lift

sonatype-lift Bot commented Jan 20, 2023

Copy link
Copy Markdown

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/15735.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow/15735.diff | git apply

Once you're satisfied commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser. ↩

@jouni

jouni commented Jan 20, 2023

Copy link
Copy Markdown
Member

I assume you left room in the API for the other options, block and inline, as well: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView, if someone would ever want those added?

@Artur-

Artur- commented Jan 21, 2023

Copy link
Copy Markdown
Member Author

Changed the API so you can give all the options available

@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Jan 21, 2023
@Artur-
Artur- force-pushed the scroll-into-smooth branch from f9ce8de to be804e8 Compare January 23, 2023 07:54
…final. Always use final except when you should not use final.
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.1.0 labels Jan 23, 2023
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati
mcollovati self-requested a review January 23, 2023 12:06
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants