Skip to content

feat: Use Vite dev server for Hilla projects by default - #15768

Merged
mshabarov merged 7 commits into
masterfrom
use-hotdeploy-for-hilla
Jan 31, 2023
Merged

mshabarov merged 7 commits into
masterfrom
use-hotdeploy-for-hilla

Conversation

@mshabarov

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jan 27, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   942 files  +  26     942 suites  +26   51m 28s ⏱️ - 3m 7s
5 897 tests +  87  5 862 ✔️ +  87  35 💤 ±0  0 ❌ ±0 
6 151 runs  +115  6 109 ✔️ +114  42 💤 +1  0 ❌ ±0 

Results for commit 91d6f9b. ± Comparison against base commit 74f3e0c.

♻️ This comment has been updated with latest results.

@mshabarov
mshabarov force-pushed the use-hotdeploy-for-hilla branch from 5c8367a to 4b6b209 Compare January 27, 2023 14:23

return prefix + url;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely the wrong class for this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found nothing better than EndpointRequestUtil, not maybe a good choice either.

@mshabarov
mshabarov force-pushed the use-hotdeploy-for-hilla branch from 1656b37 to e594b60 Compare January 27, 2023 18:04
@mshabarov

Copy link
Copy Markdown
Contributor Author

Tested with a starter project having Flow + Hilla, triggers hotdeploy mode by default as expected. Removing all related to Hilla triggers the express build mode by default as expected.

// This class belongs to fusion-endpoint and is not available in
// Flow projects. By checking for its availability, we can show the
// right project name in the Vaadin devmode gizmo
Class.forName("dev.hilla.EndpointController", false,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for more than Class.forName("dev.hilla.EndpointController") if you moved it to the flow-server package?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, changed.

@Artur-

Artur- commented Jan 30, 2023

Copy link
Copy Markdown
Member

Tested that it works correctly with start.vaadin.com

@cromoteca

Copy link
Copy Markdown
Contributor

@platosha @Lodin I propose to define a class in Hilla that is officially a marker of Hilla being used. Here dev.hilla.EndpointController is used at the moment.

@cromoteca
cromoteca requested a review from platosha January 30, 2023 15:47
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov
mshabarov requested a review from Artur- January 31, 2023 06:30
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants