Skip to content

fix: Always set development mode when in development mode - #16330

Merged
Artur- merged 2 commits into
mainfrom
dev-mode-is-dev-mode
Mar 21, 2023
Merged

Artur- merged 2 commits into
mainfrom
dev-mode-is-dev-mode

Conversation

@Artur-

@Artur- Artur- commented Mar 21, 2023

Copy link
Copy Markdown
Member

No description provided.

@Artur-
Artur- marked this pull request as ready for review March 21, 2023 07:34
@Artur-
Artur- requested a review from mshabarov March 21, 2023 07:35
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Artur-
Artur- enabled auto-merge (squash) March 21, 2023 07:47
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   955 files  ±0     955 suites  ±0   1h 2m 2s ⏱️ + 2m 12s
6 068 tests ±0  6 033 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 321 runs  ±0  6 279 ✔️ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit f5575d5. ± Comparison against base commit 3bca9fb.

// Ensure no older tools incorrectly detect a bundle as production
// mode
addScript(indexDocument,
"window.Vaadin = window.Vaadin || {}; window.Vaadin.developmentMode = true;");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exported web components probably also need this, so let's include it into WebComponentBootstrapHandler (or even only into BootstrapHandler) ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should exported web components affect global variables on the page? They probably do it already to some degree but say that you would run a Flow app in production mode and import an exported wc that is accidentally running in development mode. Should this say that the Flow app is running in development mode?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should exported web components affect global variables on the page?

This shouldn't be needed and, generally, not correct IMO.

Should this say that the Flow app is running in development mode?

Definitely not, if the app is running in prod mode :)
OK, let's not touch exported wc for now 👍

@Artur-
Artur- merged commit a6938d7 into main Mar 21, 2023
@Artur-
Artur- deleted the dev-mode-is-dev-mode branch March 21, 2023 08:16
vaadin-bot added a commit that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants