Skip to content

fix: Retry Node download if it fails - #16338

Merged
czp13 merged 4 commits into
mainfrom
retry-node-dl
Mar 21, 2023
Merged

czp13 merged 4 commits into
mainfrom
retry-node-dl

Conversation

@Artur-

@Artur- Artur- commented Mar 21, 2023

Copy link
Copy Markdown
Member

Fixes #16035

@github-actions

github-actions Bot commented Mar 21, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   953 files  ±0     953 suites  ±0   57m 41s ⏱️ - 5m 37s
6 068 tests ±0  6 033 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 320 runs  ±0  6 278 ✔️ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit 5388789. ± Comparison against base commit 48bec86.

♻️ This comment has been updated with latest results.

@Artur-
Artur- marked this pull request as ready for review March 21, 2023 12:26
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@czp13 czp13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be safe after the fix, thank you for it!

@czp13
czp13 merged commit 1b4ea30 into main Mar 21, 2023
@czp13
czp13 deleted the retry-node-dl branch March 21, 2023 18:09
vaadin-bot pushed a commit that referenced this pull request Mar 21, 2023
* fix: Retry Node download if it fails
Fixes #16035
* Only download once when successful
---------
Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
vaadin-bot pushed a commit that referenced this pull request Mar 21, 2023
* fix: Retry Node download if it fails
Fixes #16035
* Only download once when successful
---------
Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
vaadin-bot added a commit that referenced this pull request Mar 21, 2023
* fix: Retry Node download if it fails
Fixes #16035
* Only download once when successful
---------
Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>

Co-authored-by: Artur <artur@vaadin.com>
vaadin-bot added a commit that referenced this pull request Mar 21, 2023
* fix: Retry Node download if it fails
Fixes #16035
* Only download once when successful
---------
Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>

Co-authored-by: Artur <artur@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.alpha1 and is also targeting the upcoming stable 24.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retry node download if it fails

4 participants